GNOME Bugzilla – Bug 786565
sharing: Add Wayland screen sharing support
Last modified: 2017-09-29 15:34:33 UTC
This adds support for enabling/disabling screen sharing when the corresponding API is exposed by GNOME Shell. While the patches hasn't landed yet, when they will, the user still needs to explicitly enable the experimental setting. All preferences are hidden, as gnome-remote-desktop (the remote desktop implementation using the API) can't be configured yet.
Created attachment 358062 [details] [review] sharing: Add Wayland screen sharing support This allows enabling screen sharing support under Wayland, as long as the org.gnome.Mutter.RemoteDesktop D-Bus name is exported by mutter / gnome-shell. That name will currently only be exported if the corresponding experimental features has been added to mutter. So far nothing is configurable, as gnome-remote-desktop is yet to be configureable.
Review of attachment 358062 [details] [review]: ::: panels/sharing/cc-sharing-panel.c @@ +1070,3 @@ + GtkWidget *networks, *w; + + /* Don't add it nor show it, as the network selection has no effect yet. */ what do you mean by network selection having no effect? @@ +1094,3 @@ + return FALSE; + + proxy = g_dbus_proxy_new_for_bus_sync (G_BUS_TYPE_SESSION, all of this from here on down should be done asynchronously with g_bus_watch_name()
Created attachment 358701 [details] [review] sharing: Show the networks widget The way it works is independent of the service so there's no reason not to show it.
Review of attachment 358062 [details] [review]: I'll push this as is a fix it with the patch here plus bug 786984
Created attachment 358711 [details] [review] sharing: Show the networks widget in the screen sharing dialog The way it works is independent of the service so there's no reason not to show it. We should also hide the remote-control-box widget hierarchy since those can't be used here. -- The previous patch didn't hide the remote-control-box which doesn't work for us.
Attachment 358062 [details] pushed as ecb0e6d - sharing: Add Wayland screen sharing support Attachment 358711 [details] pushed as 58bad72 - sharing: Show the networks widget in the screen sharing dialog