GNOME Bugzilla – Bug 785493
[PATCH] networkAgent: advise the user to push a WPS button on their router
Last modified: 2018-12-17 15:05:55 UTC
Created attachment 356471 [details] [review] Proposed patch This is a new feature in future NetworkManager release -- NetworkManager would initiate WPS when the router supports it and the secrets are missing and it indicates that via the secret agent request flag. Windows NT does a similar thing. In their dialog they seem to use the WPS logo; not sure if that's something we should do too: http://ptgmedia.pearsoncmg.com/images/art_geier_smallwin7/elementLinks/geier_fig03.jpg http://www.dlink.cc/wp-content/uploads/2015/07/DIR-890L-WPS-Button-windows-8c.jpg
Review of attachment 356471 [details] [review]: kids are asleep in car so might as well do a drive-by (hah! park-by?) review... instead of the 0x8 constant, can you just check if NMClient.SecretAgentGetSecretsFlags.WPS_PBC_ACTIVE is defined?
I have opened https://gitlab.gnome.org/GNOME/gnome-shell/issues/235 for this.
I created https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/329 upstream to get the patch merged. The libnm dependency has been bumped, so that is not an issue anymore.