GNOME Bugzilla – Bug 782858
player: API to handle subtitle font description
Last modified: 2018-11-03 14:08:38 UTC
Adds API to handle subtitle font description. It use a property named "subtitle-font-name" which wraps "subtitle-font-desc" in playbin.
Created attachment 352203 [details] [review] player: API to handle subtitle font description
I used "subtitle_font_name()" because that what clutter and GTK+ uses in ther API. When font_description is used, it refers to PangoFontDescription structure.
ping? :D
Created attachment 371765 [details] [review] player: API to handle subtitle font description Adds API to handle subtitle font description. It use a property named "subtitle-font-name" which wraps "subtitle-font-desc" in playbin.
Created attachment 374119 [details] [review] player: API to handle subtitle font description Adds API to handle subtitle font description. It use a property named "subtitle-font-name" which wraps "subtitle-font-desc" in playbin.
Comment on attachment 374119 [details] [review] player: API to handle subtitle font description I'd prefer to have this part of the player configuration. Or is it something that is going to be changed all the time? Also this only has effect on some subtitle formats, which is a bit ugly.
Created attachment 374124 [details] [review] player: API to handle subtitle font description Adds API to handle subtitle font description. It use a property named "subtitle-font-name" which wraps "subtitle-font-desc" in playbin.
Just to a have a working patch :) But I'll rework it to have it as part of the configure structure. But also to keep in mind what philn said on IRC: > philn │ ceyusa: i think some people would prefer to have everything related to the subtitle's appearance in a single object in gst-player
Comment on attachment 374124 [details] [review] player: API to handle subtitle font description I'd prefer to have this part of the player configuration. Or is it something that is going to be changed all the time? Also this only has effect on some subtitle formats, which is a bit ugly.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/558.