After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781281 - Deleting a playlist and closing Music within 5 seconds does not delete the playlist.
Deleting a playlist and closing Music within 5 seconds does not delete the pl...
Status: RESOLVED OBSOLETE
Product: gnome-music
Classification: Applications
Component: general
3.24.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2017-04-13 16:45 UTC by Abhinav Singh
Modified: 2018-01-10 15:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: Execute playlist deletion on quit window (2.35 KB, patch)
2017-04-15 10:05 UTC, Abhinav Singh 		reviewed Details | Review

Description Abhinav Singh 2017-04-13 16:45:41 UTC 
Reproduce:

1: Delete the playlist
2: Close Music within 5 seconds
3: Restart Music

The playlist is still present.
Comment 1 Marinus Schraal 2017-04-14 06:22:37 UTC 
Should be part of the quit calls to remove the pending playlist.
Comment 2 Abhinav Singh 2017-04-15 10:05:45 UTC 
Created attachment 349885 [details] [review]
window: Execute playlist deletion on quit window

Connect to 'delete-event' of window to finish the queued playlist
deletion and appropriately disconnect at undo or successful deletion.
Comment 3 Marinus Schraal 2017-04-16 11:21:58 UTC 
Review of attachment 349885 [details] [review]:

I was looking at this and I'm not sure I agree with the overall approach here. To me it looks we're filling up window.py with code that shouldn't be there in the first place.

To me deleting a playlist belongs in the playlist class, it should just be a call, possibly with an added time-out (for the undo).

So, something like playlists.delete_playlist(playlist, delay).

To make sure it gets deleted on exit there should be a destructor type of function (sadly python is bad at this). So in the tear down there should be a call somewhere to eg. playlists.cleanup(), which removes the playlist if it's within the delay time.
Comment 4 GNOME Infrastructure Team 2018-01-10 15:04:28 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-music/issues/106.