GNOME Bugzilla – Bug 780745
[PATCH] Preparing for genitive/nominative month names
Last modified: 2017-11-24 22:14:54 UTC
Created attachment 349019 [details] [review]
Use nominative/genitive months as long as they are supported by the OS
Please don't commit this patch yet unless you really like it. There is indeed a problem in GNOME Calendar as well as in many (most? all?) other applications that they format dates incorrectly in about 20 languages, mostly from eastern Europe. This is not a genuine bug of GNOME Calendar, the root cause is deep in glibc: https://sourceware.org/bugzilla/show_bug.cgi?id=10871. So in order for this patch to work correctly the bug in glibc must be fixed first. There is also a related bug in glib2: bug 749206.
On the other hand, thanks to the autoconf features this patch is not destructive, simply will not change anything in Linux system. Also, as *BSD systems have been supporting nominative/genitive month names since late 1990s it will start working correctly immediately. So, it's up to you if you want to commit now or wait several months.
Review of attachment 349019 [details] [review]:
Nice patch. A couple nitpicks, but otherwise good to go:
- The commit message does not follow GNOME Calendar standards. Please follow the standard described here: https://wiki.gnome.org/Newcomers/SubmitPatch
- See below:
@@ +52,3 @@
Can you please write a comment before the #ifdef explaining the ALTMON usage?
Thank you for the review. OK, I will rework the patch but again I suggest not to push it, at least unless GNOME community decides whether and how to adopt the changes and what can we expect from Linux in the future. I just wrote an email to the gnome-i18n list asking about the translators' opinion: https://mail.gnome.org/archives/gnome-i18n/2017-April/msg00054.html
(In reply to Georges Basile Stavracas Neto from comment #1)
> Review of attachment 349019 [details] [review] [review]:
> Nice patch. A couple nitpicks, but otherwise good to go:
> - The commit message does not follow GNOME Calendar standards. Please
> follow the standard described here:
It's not clear to me what should be changed. Missing link to this bug report? That's obvious because I prepared the patch before opening the bugzilla ticket. The short title does not start with "modified-file:"? Could you please explain what should be there if there are more than one files modified?
Also I have a feeling that the commit message will have to be completely reworked once the related bugs are fixed.
> - See below:
> ::: src/gcal-utils.c
> @@ +52,3 @@
> month_item =
> +#ifdef HAVE_ALTMON
> Can you please write a comment before the #ifdef explaining the ALTMON usage?
OK, I will do it.
-- GitLab Migration Automatic Message --
This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.
You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-calendar/issues/125.