After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780212 - Do not lock the screen when disabled by lockdown settings
Do not lock the screen when disabled by lockdown settings
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-03-17 17:13 UTC by Florian Müllner
Modified: 2017-03-20 18:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenShield: Do not lock the screen when locked down (2.49 KB, patch)
2017-03-17 17:13 UTC, Florian Müllner
committed Details | Review
screenShield: Do not take an inhibitor when disabled by lockdown (1.73 KB, patch)
2017-03-17 17:13 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2017-03-17 17:13:02 UTC
See patches.
Comment 1 Florian Müllner 2017-03-17 17:13:07 UTC
Created attachment 348191 [details] [review]
screenShield: Do not lock the screen when locked down

When using the 'disable-lock-screen' setting to lock down the screen
lock, the expectation is that users cannot lock the screen. However
as it turns out, all the setting currently does is hiding the lock
button in the system menu and making the lock settings in the privacy
panel inactive. That means that if the 'lock-screen-enabled' setting
isn't disabled and locked down as well, we will just continue to
lock the screen on inactivity - not to mention the keyboard shortcut
that isn't subject to that setting anyway.

Instead of expecting administrators to hunt down every possible way
of locking the screen and disabling it individually, we can easily
handle all cases by refusing to lock the screen when disabled by the
lockdown settings.
Comment 2 Florian Müllner 2017-03-17 17:13:14 UTC
Created attachment 348192 [details] [review]
screenShield: Do not take an inhibitor when disabled by lockdown

Just as with the normal lock screen settings, we shouldn't request
a logind inhibitor when locking is disabled via lockdown settings.
Comment 3 Rui Matos 2017-03-20 13:36:20 UTC
Review of attachment 348191 [details] [review]:

looks obviously fine

wonder why it wasn't like this already...
Comment 4 Rui Matos 2017-03-20 13:36:44 UTC
Review of attachment 348192 [details] [review]:

lgtm
Comment 5 Florian Müllner 2017-03-20 18:15:02 UTC
Attachment 348191 [details] pushed as 199bc85 - screenShield: Do not lock the screen when locked down
Attachment 348192 [details] pushed as a786f0b - screenShield: Do not take an inhibitor when disabled by lockdown