GNOME Bugzilla – Bug 779471
Todo.txt: close button have no action in revealer
Last modified: 2020-11-25 16:21:20 UTC
In the revealer related to Todo.txt, the close button have no action. How to reproduce: 1. create a new calendar with Todo.txt source 2. Add some invalid text eg: "one + two" Result: A revealer is shown. Clicking the close button in the revealer does nothing. And the revealer is withdrawn automatically after timeout.
I would Like to work on this Issue, but I can't reproduce the bug. Can you say how to create a calender with a Todo.txt source?
(In reply to Aswin Mohan from comment #1) > I would Like to work on this Issue, but I can't reproduce the bug. Can you > say how to create a calender with a Todo.txt source? Hi, welcome to GNOME. Hope you have installed the latest gnome-todo from source code repository (using jhbuild/flatpak), if not see Newcomers guide[0]. Once you have installed the latest gnome-todo run it. You can create a List in Todo.txt source by clicking "New List" -> Click on the monitor like icon present near by the name entry -> Select "On the Todo.txt file" -> Name it something -> click "Create List". [0] https://wiki.gnome.org/Newcomers
I can't recreate the bug because when I click on "New list" I haven't the monitor like button, instead I have only the G of Google and every new list I make is synced with Google. Is it a new bug or am I missing something?
Sorry, I resolved this problem but I have a new one. When I click on the little monitor like button the only option I have is "On this computer, local" and there's not todo.txt option.
(In reply to Samuele from comment #4) > Sorry, I resolved this problem but I have a new one. > When I click on the little monitor like button the only option I have is "On > this computer, local" and there's not todo.txt option. Hi. The build of todo.txt was briefly disabled before 3.24 release. Now it's back on. If you have a slightly non upto-date repo, todo.txt might be disabled by default. So please update your git repo and build again (Hope you are using jhbuild). You can seek help at #gnome-todo channel in GNOME IRC network. Thanks
Created attachment 350851 [details] [review] Close notification revealer when 'X' is clicked
Unable to reproduce. Seems to be working fine for me. (In reply to Linus Probert from comment #6) > Created attachment 350851 [details] [review] [review] > Close notification revealer when 'X' is clicked Tried this patch. Same behavior
Created attachment 351159 [details] A gif showing the bug This is a gif showing what happens when I reproduce this bug on my machine.
(In reply to Linus Probert from comment #8) > Created attachment 351159 [details] > A gif showing the bug > > This is a gif showing what happens when I reproduce this bug on my machine. Sorry. I was a bit unclear on how to reproduce the bug. How to reproduce: 1. Open gnome-todo -> New List -> Select Todo.txt as source (from the monitor like icon near the entry) 2. Name the list (eg: Test) -> Create List 3. Now open the newly created list (Click "Test" from the list) 4. Put in some invalid ToDo entry. eg: one + two 5. The error revealer now shown doesn't hide when the close button is clicked. Hope this is clear enough. Thanks
Ok, I think it's the same notification object still so my patch should cover both mine and your scenario.
Review of attachment 350851 [details] [review]: Just a minor nitpick in the code, and please remove the 'gtd-' prefix of the commit title. ::: src/notification/gtd-notification-widget.c @@ +122,3 @@ gtd_notification_stop (priv->current_notification); gtd_notification_execute_primary_action (priv->current_notification); + gtd_notification_widget_stop_or_run(widget); Wrong style (missing space between '(' and function name).
Created attachment 351510 [details] [review] Close notification revealer when 'X' is clicked
Review of attachment 351510 [details] [review]: After applying this patch, I couldn't make the notification show/hide when clicking the close button.
Perhaps there is more that needs fixing? The gif that I submitted is the scenario I worked on.
I actually found an another issue. When I enter a task I am getting error msg stating "Error while opening todo.txt".
I installed the latest version using of gnome todo using flatpack. I don't get any error like this. I tried adding a todo as "one + two" and also one + two, both were created as successful todos
I've downloaded the latest from master branch (3.27.2-GNOME_TODO_3_27_2-6-gea8aec7) and I cannot see the bug as Shameem Fairooz already said.
bugzilla.gnome.org is being replaced by gitlab.gnome.org. We are closing all older bug reports and feature requests in GNOME Bugzilla which have not seen updates for a while. If you still use gnome-todo and if you still see this bug / want this feature in a recent and currently supported version, then please feel free to report it at https://gitlab.gnome.org/GNOME/gnome-todo/-/issues/ by following the guidelines at https://wiki.gnome.org/Community/GettingInTouch/BugReportingGuidelines Thank you for creating this report and we are sorry it could not be implemented so far (volunteer workforce and time is limited).