After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779422 - qtmux: Update modification times when sending the moov
qtmux: Update modification times when sending the moov
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.11.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-01 15:10 UTC by Sebastian Dröge (slomo)
Modified: 2017-03-02 18:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtmux: Update modification times when sending the moov (2.71 KB, patch)
2017-03-01 15:10 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2017-03-01 15:10:22 UTC 
Together with robust muxing that allows to know when the last update was from
the file headers.
Comment 1 Sebastian Dröge (slomo) 2017-03-01 15:10:28 UTC 
Created attachment 346975 [details] [review]
qtmux: Update modification times when sending the moov
Comment 2 Jan Schmidt 2017-03-02 04:43:00 UTC 
Review of attachment 346975 [details] [review]:

Looks fine
Comment 3 Thiago Sousa Santos 2017-03-02 17:55:01 UTC 
Review of attachment 346975 [details] [review]:

::: gst/isomp4/gstqtmux.c
@@ +1937,3 @@
+        atoms_get_current_qt_time ();
+    qtpad->trak->tkhd.modification_time = atoms_get_current_qt_time ();
+  }

How about getting the time just once and writing the same all over. I guess there is a small chance that the times will be slightly different.

Not sure it matters in the end but it seems to make more sense to have them all with a common value.
Comment 4 Sebastian Dröge (slomo) 2017-03-02 18:33:39 UTC 
Attachment 346975 [details] pushed as 7709920 - qtmux: Update modification times when sending the moov