After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779122 - Shortcuts don't work when diff is opened having non-English keyboard layout
Shortcuts don't work when diff is opened having non-English keyboard layout
Status: RESOLVED OBSOLETE
Product: meld
Classification: Other
Component: general
3.16.x
Other Windows
: Normal normal
: ---
Assigned To: meld-maint
meld-maint
Depends on:
Blocks:
 
 
Reported: 2017-02-23 08:49 UTC by dmytro.puzhay
Modified: 2017-12-13 19:23 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description dmytro.puzhay 2017-02-23 08:49:53 UTC
Reproduce:
- start new comparison (file of dir)
- select file to diff
- switch your keyboard layout to a non-English one
- press enter
- shortcuts like Crl+F don't work, even if you switch to English keyboard layout

Workaround:
- close the diff
- switch keyboard layout to English
- reopen file diff
- repeat until you are very, very annoyed :)
Comment 1 Kai Willadsen 2017-02-23 20:54:28 UTC
Is this a Meld-specific bug? We don't do anything special that I can think of for keyboard shortcuts here, so I'd expect this to be consistent with how GTK+ handles shortcuts.
Comment 2 dmytro.puzhay 2017-02-23 22:03:51 UTC
Emmm, don't know, I am using Meld for Windows. Maybe you do something special with keyboard layouts?
Comment 3 Kai Willadsen 2017-02-26 03:44:55 UTC
Ah, sure. Sorry I didn't notice the Windows platform field.

In that case, I'm sorry but I suspect that this is a GTK+ on Windows bug. I have no idea how keyboard layout stuff happens on Windows, but we don't have any custom hooks for it, so it's unlikely that it's Meld causing this directly.

Either way, I'll leave this open because it's a real problem, but I don't know whether it's something we'll be able to fix other than by getting it fixed in GTK+ and updating the base platform we ship with.
Comment 4 Vasily Galkin 2017-02-26 15:26:08 UTC
I almost always has the similar issue with meld on Windows, though I failed figured out the strict dependency between the issue and current keyboard layout.

It may be old-standing gtk's bug https://bugzilla.gnome.org/show_bug.cgi?id=768722
 which recently was fixed by 
https://git.gnome.org/browse/gtk+/commit?id=52c7e07948f0d82ade7c730e99c53dea3e13ca67 (and maybe some later) additional fixes. As far as I know this wasn't included in pygobject-win32 binaries yet.
Comment 5 dmytro.puzhay 2017-02-26 15:40:14 UTC
"I don't know whether it's something we'll be able to fix other than by getting it fixed in GTK+ and updating the base platform we ship with"
+
"I almost always has the similar issue with meld on Windows, though I failed figured out the strict dependency between the issue and current keyboard layout"

It's actually very easy to reproduce - just follow the steps in bug description :)

Could maybe somebody check if it's reproducible after the fix or ask gtk developers to test it? I am not into GTK+ development :(
Comment 6 Vasily Galkin 2017-02-28 17:10:26 UTC
I tried running meld on windows with python3.5 and gtk3.22 installed by msys2-mingw64 package manager pacman.

After adding temporarily hacks around some incompatibility issues (like getenv vs getenv_utf8 naming) meld successfully shows file diff and all Ctrl+key bindings works fine regardless of layout.

Note that the difference is not only gtk version: the gtk dlls where I have key binding problems are from pygobject-win32 project, which maybe uses some different build options.
Comment 7 Kai Willadsen 2017-03-10 23:03:11 UTC
Thanks for testing that out!

I haven't yet started to set up a Windows build environment for the Meld 3.17 release series. While I've had fairly good experiences with the pygobject-win32 binaries, I'm not totally against switching to something else if it's well maintained and simple to use.

I'd like to be able to eventually move these builds to a cloud service so that they're reproducible and don't rely on very specific and finicky setups, but I honestly don't have the time or inclination to tackle that right now.

If anyone wanted to step in here that would be amazing.
Comment 8 GNOME Infrastructure Team 2017-12-13 19:23:49 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/meld/issues/129.