After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 778666 - Needs its own thumbnailer
Needs its own thumbnailer
Status: RESOLVED FIXED
Product: librsvg
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: librsvg maintainers
librsvg maintainers
: 780956 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-02-15 11:15 UTC by Bastien Nocera
Modified: 2017-06-27 22:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add .thumbnailer file for gdk-pixbuf-loader (1.72 KB, patch)
2017-04-06 11:16 UTC, Jeremy Bicha
none Details | Review
Add .thumbnailer file for gdk-pixbuf-loader (1.72 KB, patch)
2017-04-06 11:24 UTC, Jeremy Bicha
none Details | Review
Add .thumbnailer file for gdk-pixbuf-loader (2.40 branch) (1.77 KB, patch)
2017-04-06 11:51 UTC, Jeremy Bicha
none Details | Review
Add .thumbnailer file for gdk-pixbuf-loader (1.74 KB, patch)
2017-04-06 12:23 UTC, Jeremy Bicha
none Details | Review
Add .thumbnailer file for gdk-pixbuf-loader (2.40 branch) (1.79 KB, patch)
2017-04-06 12:24 UTC, Jeremy Bicha
none Details | Review

Description Bastien Nocera 2017-02-15 11:15:20 UTC
gnome-desktop used to special-case gdk-pixbuf supported image types, checking whether they were supported at run-time.

As librsvg creates its own gdk-pixbuf module, and the .thumbnailer file for gdk-pixbuf is created at compile-time, librsvg needs to either create a .thumbnailer file that would reference gdk-pixbuf-thumbnailer, or, better, create its own thumbnailer helper.
Comment 1 Bastien Nocera 2017-04-06 09:13:31 UTC
*** Bug 780956 has been marked as a duplicate of this bug. ***
Comment 2 Jeremy Bicha 2017-04-06 11:16:58 UTC
Created attachment 349354 [details] [review]
Add .thumbnailer file for gdk-pixbuf-loader

This is required for svg thumbnails to work with gnome-desktop 3.24
Comment 3 Jeremy Bicha 2017-04-06 11:24:26 UTC
Created attachment 349355 [details] [review]
Add .thumbnailer file for gdk-pixbuf-loader

remove extra spaces
Comment 4 Jeremy Bicha 2017-04-06 11:51:44 UTC
Created attachment 349356 [details] [review]
Add .thumbnailer file for gdk-pixbuf-loader (2.40 branch)

This is required for svg thumbnails to work with gnome-desktop 3.24

Here's the commit for the librsvg-2-40 branch since that's what I expect GNOME 3.24 distros to ship.
Comment 5 Christian Persch 2017-04-06 12:01:19 UTC
MimeType=image/svg+xml;

Can you add "image/svg+xml-compressed" to that? Or is the thumbnailer unable to operate on gzipped svg files?
Comment 6 Jeremy Bicha 2017-04-06 12:15:36 UTC
Do you have an example svgz file I could try?
Comment 7 Jeremy Bicha 2017-04-06 12:23:10 UTC
Created attachment 349358 [details] [review]
Add .thumbnailer file for gdk-pixbuf-loader

This is required for svg thumbnails to work with gnome-desktop 3.24


Ok, I found a sample .svgz and confirmed that the thumbnailer works:

http://www.cs.queensu.ca/students/undergraduate/prerequisites/COMP17.svgz

or any of the files on the /prerequisites/ page
Comment 8 Jeremy Bicha 2017-04-06 12:24:09 UTC
Created attachment 349359 [details] [review]
Add .thumbnailer file for gdk-pixbuf-loader (2.40 branch)

for the librsvg-2-40 branch
Comment 9 Federico Mena Quintero 2017-04-07 20:25:46 UTC
Thanks for the patches!  I'll release 2.40.17 right away.
Comment 10 Federico Mena Quintero 2017-06-27 22:02:36 UTC
Forgot to close this bug.