After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776431 - dashdemux: Fix regression of On-Demand profile mpd playback
dashdemux: Fix regression of On-Demand profile mpd playback
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-12-23 07:02 UTC by Seungha Yang
Modified: 2016-12-23 10:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
dashdemux: Ensure sidx parsing when updating fragment info (1.18 KB, patch)
2016-12-23 07:04 UTC, Seungha Yang
committed Details | Review
dashdemux: Add first_offset of sidx box to base offset (1.25 KB, patch)
2016-12-23 07:05 UTC, Seungha Yang
committed Details | Review

Description Seungha Yang 2016-12-23 07:02:31 UTC
Fix test fail of gst-validate test case (exMPD_BIP_TC1) by previous sidx related patches

exMPD_BIP_TC1.mpd on gst-validate has two special feature
- Only "BaseURL" element exist (no header url info such as indexRange)
- Sidx box has non-zero "first_offset" value

Note that, sidx has "first_offset" syntax which represents the distance in bytes from anchor point to media fragment. Here, the anchor point is the next byte of end of sidx box.
Usually, the first media fragment located right after sidx box (in this case first_offset should be zero). However, if there are addtional top level boxes between sidx and the first moof, the "first_offset" value in sidx box has non-zero value.
Comment 1 Seungha Yang 2016-12-23 07:04:15 UTC
Created attachment 342406 [details] [review]
dashdemux: Ensure sidx parsing when updating fragment info

Fix seek fail with On-Demand profile mpd which has no indexRange attribute
Comment 2 Seungha Yang 2016-12-23 07:05:12 UTC
Created attachment 342407 [details] [review]
dashdemux: Add first_offset of sidx box to base offset

sidx has "first_offset" syntax which represents the distance in bytes
from anchor point to media fragment. If present, we should adjust
sidx_base_offset.
Comment 3 Sebastian Dröge (slomo) 2016-12-23 10:17:21 UTC
Attachment 342406 [details] pushed as c0540fb - dashdemux: Ensure sidx parsing when updating fragment info
Attachment 342407 [details] pushed as 4523cff - dashdemux: Add first_offset of sidx box to base offset