After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 776365 - Correct vapi build dependencies
Correct vapi build dependencies
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
3.23.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2016-12-22 00:20 UTC by Christian Hergert
Modified: 2017-01-04 10:07 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christian Hergert 2016-12-22 00:20:32 UTC
This is causing gnome-apps-nightly to fail for Calendar, Todo, etc.

http://sdkbuilder1.gnome.org//logs/build-2016-12-21-140940/build-gnome-apps-nightly-master-org.gnome.Calendar-x86_64.txt

Here is an example of their configure stage:

https://git.gnome.org/browse/gnome-apps-nightly/tree/org.gnome.Calendar.json#n63

I'm happy to update the flatpaks if I can get some insight into while the vapi generation is failing. While I'm quite familiar with autotools, I am not with cmake.
Comment 1 Christian Hergert 2016-12-22 01:12:20 UTC
Maps is also broken, albeit slightly different cmake error.

http://sdkbuilder1.gnome.org//logs/build-2016-12-21-140940/build-gnome-apps-nightly-master-org.gnome.Maps-x86_64.txt
Comment 2 Milan Crha 2016-12-22 11:43:02 UTC
Thanks for a bug report. I fixed the Maps issue with commit 6ee4217 (3.23.4+), but I'm not able to reproduce the gnome-apps-nightly build failure. Are you sure it uses the updated git master of the eds there, please? It says just before the cmake call:
> Already on 'master'
but I do not know whether it also did the `git pull` there. I tried to reproduce locally with the same options as you used and it succeeded, also building out of the source tree. Finally, the error looks like bug #775963, or is related to it at least.
Comment 3 Christian Hergert 2016-12-24 23:55:29 UTC
(In reply to Milan Crha from comment #2)
> Thanks for a bug report. I fixed the Maps issue with commit 6ee4217
> (3.23.4+), but I'm not able to reproduce the gnome-apps-nightly build
> failure. Are you sure it uses the updated git master of the eds there,
> please? It says just before the cmake call:
> > Already on 'master'

flatpak-builder ensures that the source trees are up to date before the build. (All network activity is done up front, before building starts).

> but I do not know whether it also did the `git pull` there. I tried to
> reproduce locally with the same options as you used and it succeeded, also
> building out of the source tree. Finally, the error looks like bug #775963,
> or is related to it at least.

It is likely related to bug #775963. With a quick glance at the committed patch, I'd anticipate something related to locating dependent vapi for sources in tree.
Comment 4 Milan Crha 2017-01-02 13:09:20 UTC
(In reply to Christian Hergert from comment #3)
> It is likely related to bug #775963. With a quick glance at the committed
> patch, I'd anticipate something related to locating dependent vapi for
> sources in tree.

Right, and it works just fine for me.

Is it possible to reproduce the flatpack-builder environment anyhow locally, please? My usual build just works. The jhbuild (used by gnome-continuos, if I'm not mistaken) works as well (I do not know their exact setup though). Thus it points to something in the flatpack.
Comment 5 Christian Hergert 2017-01-04 00:04:11 UTC
(In reply to Milan Crha from comment #4)
> Is it possible to reproduce the flatpack-builder environment anyhow locally,
> please? My usual build just works. The jhbuild (used by gnome-continuos, if
> I'm not mistaken) works as well (I do not know their exact setup though).
> Thus it points to something in the flatpack.

Yeah, try this:

sudo dnf install flatpak-builder

flatpak --user remote-add gnome-nightly --from https://sdk.gnome.org/gnome-nightly.flatpakrepo
flatpak --user install gnome-nightly org.gnome.Platform
flatpak --user install gnome-nightly org.gnome.Sdk

git clone git://git.gnome.org/gnome-apps-nightly
cd gnome-apps-nightly
flatpak-builder --ccache --force-clean mybuild org.gnome.Todo.json
Comment 6 Milan Crha 2017-01-04 10:07:20 UTC
Thanks for the commands, it helped significantly. I realized that the vapi files had wrong dependencies set and fixed it. With it the build of the eds succeeded.

Created commit d0cccbf in eds master (3.23.4+)