After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775901 - Search manipulates Grilo search_source directly
Search manipulates Grilo search_source directly
Status: RESOLVED OBSOLETE
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Low minor
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2016-12-09 20:10 UTC by Sambhav Kothari
Modified: 2018-01-10 14:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
grilo.py: Set a default search_source value if none (1.12 KB, patch)
2016-12-09 20:28 UTC, Sambhav Kothari 		rejected Details | Review

Description Sambhav Kothari 2016-12-09 20:10:04 UTC 
TraceBack:

https://www.irccloud.com/pastebin/4eM3BhhZ/traceback

A query is called when the search source is set to None in get_album_art_for_item() . This causes an attribute error.
Comment 1 Sambhav Kothari 2016-12-09 20:28:14 UTC 
Created attachment 341690 [details] [review]
grilo.py: Set a default search_source value if none

Set the search_source to tracker in get_album_art_for_item() method if
when search source is none as otherwise a query is called on a NoneType
object which causes an AttributeError.

This happens when switching search source options back to default by
dismissing the current source.
Comment 2 Marinus Schraal 2016-12-09 21:53:29 UTC 
Review of attachment 341690 [details] [review]:

Well, actually I am aware of this issue. However, the issue is a whole lot deeper and actually is stuff needing a rewrite. Just setting it to something is not the solution.
Comment 3 GNOME Infrastructure Team 2018-01-10 14:59:33 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-music/issues/86.