After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775287 - qtdemux: change off_t type to gint
qtdemux: change off_t type to gint
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Windows
: Normal normal
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2016-11-28 21:48 UTC by Scott D Phillips
Modified: 2016-11-29 11:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

qtdemux: Change off_t type to gint (1.70 KB, patch)
2016-11-28 21:49 UTC, Scott D Phillips
committed Details | Review

Description Scott D Phillips 2016-11-28 21:48:19 UTC
off_t is a signed integer type provided by sys/types.h on posix systems. Replace with gint for building on non-posix systems (like windows).
Comment 1 Scott D Phillips 2016-11-28 21:49:11 UTC
Created attachment 340947 [details] [review]
qtdemux: Change off_t type to gint
Comment 2 Sebastian Dröge (slomo) 2016-11-28 21:58:06 UTC
There's also goffset (~ off64_t), but this also seems ok in this context. Ideally this should be rewritten around GstByteReader though, should also make the code clearer.
Comment 3 Sebastian Dröge (slomo) 2016-11-29 11:12:37 UTC
Attachment 340947 [details] pushed as 4ec5dab - qtdemux: Change off_t type to gint