After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 774623 - basetransform: Ensure to set the RECONFIGURE flag again if reconfiguration failed
basetransform: Ensure to set the RECONFIGURE flag again if reconfiguration fa...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 1.11.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-11-17 15:38 UTC by Sebastian Dröge (slomo)
Modified: 2016-11-18 10:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
basetransform: Ensure to set the RECONFIGURE flag again if reconfiguration failed (1.29 KB, patch)
2016-11-17 15:38 UTC, Sebastian Dröge (slomo)
committed Details | Review
rtpbasepayload: Ensure to set the RECONFIGURE flag again if reconfiguration failed (2.37 KB, patch)
2016-11-17 17:47 UTC, Sebastian Dröge (slomo)
committed Details | Review
dvdec: Fix handling of negotiation failures (1.96 KB, patch)
2016-11-17 18:00 UTC, Sebastian Dröge (slomo)
committed Details | Review
deinterlace: Mark pad as needing reconfiguration again if reconfiguration failed (2.01 KB, patch)
2016-11-17 18:00 UTC, Sebastian Dröge (slomo)
committed Details | Review
monoscope: Mark pad as needing reconfiguration again if it failed (1.20 KB, patch)
2016-11-17 18:00 UTC, Sebastian Dröge (slomo)
committed Details | Review
rtpmux: Mark pad as needing reconfiguration again if it failed (1.61 KB, patch)
2016-11-17 18:00 UTC, Sebastian Dröge (slomo)
committed Details | Review
textoverlay: Mark pad as needing reconfiguration again if it failed (1.69 KB, patch)
2016-11-17 18:19 UTC, Sebastian Dröge (slomo)
committed Details | Review
assrender: Mark pad as needing reconfiguration again if reconfiguration failed (1.97 KB, patch)
2016-11-17 18:21 UTC, Sebastian Dröge (slomo)
committed Details | Review
ttmlrender: Mark pad as needing reconfiguration again if it failed (1.85 KB, patch)
2016-11-17 18:21 UTC, Sebastian Dröge (slomo)
committed Details | Review
videoaggregator: Mark pad as needing reconfiguration again if it failed (1.48 KB, patch)
2016-11-17 18:21 UTC, Sebastian Dröge (slomo)
committed Details | Review
vtdec: Mark pad as needing reconfiguration again if it failed (1.16 KB, patch)
2016-11-17 18:22 UTC, Sebastian Dröge (slomo)
committed Details | Review
vc1parse: Mark pad as needing reconfiguration again if it failed (2.71 KB, patch)
2016-11-17 18:22 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2016-11-17 15:38:05 UTC
See commit message
Comment 1 Sebastian Dröge (slomo) 2016-11-17 15:38:09 UTC
Created attachment 340135 [details] [review]
basetransform: Ensure to set the RECONFIGURE flag again if reconfiguration failed

It might've failed just because of flushing or other things, and we
should retry again on the next possibility if something ever calls in
here again.
Comment 2 Sebastian Dröge (slomo) 2016-11-17 15:55:42 UTC
Should probably double-check all other places where we make use of the RECONFIGURE flag.
Comment 3 Sebastian Dröge (slomo) 2016-11-17 17:47:27 UTC
Created attachment 340156 [details] [review]
rtpbasepayload: Ensure to set the RECONFIGURE flag again if reconfiguration failed
Comment 4 Sebastian Dröge (slomo) 2016-11-17 18:00:28 UTC
Created attachment 340157 [details] [review]
dvdec: Fix handling of negotiation failures

Return NOT_NEGOTIATED if sending the caps event fails, or FLUSHING if
the pad was flushing at that point.
Comment 5 Sebastian Dröge (slomo) 2016-11-17 18:00:34 UTC
Created attachment 340158 [details] [review]
deinterlace: Mark pad as needing reconfiguration again if reconfiguration failed

And consider negotiation failures on flushing pads as FLUSHING, not as
NOT_NEGOTIATED.
Comment 6 Sebastian Dröge (slomo) 2016-11-17 18:00:44 UTC
Created attachment 340159 [details] [review]
monoscope: Mark pad as needing reconfiguration again if it failed

And return FLUSHING instead of NOT_NEGOTIATED on flushing pads.
Comment 7 Sebastian Dröge (slomo) 2016-11-17 18:00:50 UTC
Created attachment 340160 [details] [review]
rtpmux: Mark pad as needing reconfiguration again if it failed

And return FLUSHING instead of NOT_NEGOTIATED on flushing pads.
Comment 8 Sebastian Dröge (slomo) 2016-11-17 18:19:29 UTC
Created attachment 340162 [details] [review]
textoverlay: Mark pad as needing reconfiguration again if it failed

And return FLUSHING instead of NOT_NEGOTIATED on flushing pads.
Comment 9 Sebastian Dröge (slomo) 2016-11-17 18:21:47 UTC
Created attachment 340163 [details] [review]
assrender: Mark pad as needing reconfiguration again if reconfiguration failed

Also return FLUSHING instead of NOT_NEGOTIATED on flushing pads.
Comment 10 Sebastian Dröge (slomo) 2016-11-17 18:21:52 UTC
Created attachment 340164 [details] [review]
ttmlrender: Mark pad as needing reconfiguration again if it failed

And return FLUSHING instead of NOT_NEGOTIATED on flushing pads.
Comment 11 Sebastian Dröge (slomo) 2016-11-17 18:21:57 UTC
Created attachment 340165 [details] [review]
videoaggregator: Mark pad as needing reconfiguration again if it failed

And return FLUSHING instead of NOT_NEGOTIATED on flushing pads.
Comment 12 Sebastian Dröge (slomo) 2016-11-17 18:22:03 UTC
Created attachment 340166 [details] [review]
vtdec: Mark pad as needing reconfiguration again if it failed

And return FLUSHING instead of NOT_NEGOTIATED on flushing pads.
Comment 13 Sebastian Dröge (slomo) 2016-11-17 18:22:09 UTC
Created attachment 340167 [details] [review]
vc1parse: Mark pad as needing reconfiguration again if it failed

And return FLUSHING instead of NOT_NEGOTIATED on flushing pads.
Comment 14 Sebastian Dröge (slomo) 2016-11-18 10:37:01 UTC
Comment on attachment 340135 [details] [review]
basetransform: Ensure to set the RECONFIGURE flag again if reconfiguration failed

Attachment 340135 [details] pushed as f08c8d2 - basetransform: Ensure to set the RECONFIGURE flag again if reconfiguration failed
Comment 15 Sebastian Dröge (slomo) 2016-11-18 10:37:54 UTC
Attachment 340156 [details] pushed as b9f59fd - rtpbasepayload: Ensure to set the RECONFIGURE flag again if reconfiguration failed
Attachment 340162 [details] pushed as d34e326 - textoverlay: Mark pad as needing reconfiguration again if it failed
Comment 16 Sebastian Dröge (slomo) 2016-11-18 10:38:22 UTC
Attachment 340157 [details] pushed as f32603b - dvdec: Fix handling of negotiation failures
Attachment 340158 [details] pushed as 858d9f9 - deinterlace: Mark pad as needing reconfiguration again if reconfiguration failed
Attachment 340159 [details] pushed as a9b1aa1 - monoscope: Mark pad as needing reconfiguration again if it failed
Attachment 340160 [details] pushed as 15630db - rtpmux: Mark pad as needing reconfiguration again if it failed
Comment 17 Sebastian Dröge (slomo) 2016-11-18 10:38:58 UTC
Attachment 340163 [details] pushed as b2dd97a - assrender: Mark pad as needing reconfiguration again if reconfiguration failed
Attachment 340164 [details] pushed as a1dc37b - ttmlrender: Mark pad as needing reconfiguration again if it failed
Attachment 340165 [details] pushed as db504c9 - videoaggregator: Mark pad as needing reconfiguration again if it failed
Attachment 340166 [details] pushed as 279fb3d - vtdec: Mark pad as needing reconfiguration again if it failed
Attachment 340167 [details] pushed as 0f657ce - vc1parse: Mark pad as needing reconfiguration again if it failed