GNOME Bugzilla – Bug 772994
core dump when right clicking on the URL Bar
Last modified: 2016-11-28 21:13:52 UTC
Created attachment 337765 [details] Epiphany core dump while right click on the location bar. Hi,... when i do a right click on the location bar (to copy an URL into clipboard), epiphany crashes reproducible. A left click on the location bar and then "Ctrl"+"C" works just fine, to copy an URL into clipboard. best regards
I can't reproduce this. I need a full stack trace of the crashing thread (using 'bt full') with all debuginfo packages installed (at least for GLib, GTK+, and Epiphany) so that we get line numbers and local variables. Thanks for taking the time to report this. Without a stack trace from the crash it's very hard to determine what caused it. Can you get us a stack trace? Please see https://wiki.gnome.org/Community/GettingInTouch/Bugzilla/GettingTraces for more information on how to do so. When pasting a stack trace in this bug report, please reset the status of this bug report from NEEDINFO to its previous status. Thanks in advance!
(Clearly from the trace you posted something is going wrong with a GBinding, but I don't see what.)
I experience the same problem and checked the code. In my case it is a translation issue. In ephy-location-entry.c is a binding between "paste_menuitem" and "paste_and_go_menuitem". The german translation for "_Paste" in epiphany is different from the translation of GtkEntry. So line 667 in ephy-location-entry.c is never reached and it fails to create the binding. An updated german translation fixed the problem for me. I requested a change of the translation, too (https://l10n.gnome.org/vertimus/epiphany/gnome-3-22/po/de). There could be more translations with this problem.
I just started Epiphany from console with "LANG=C epiphany". Works fine. Still need a full stack trace? I can do it, but I have to install a lot of packages and possible also do some reading before. :)
In which language are you experiencing the problem? Translations are not handled by the developers, but by the translation teams (via https://l10n.gnome.org). If you use epiphany in another language than german, there is probably an error in another language which should be reported to the corresponding language team.
(In reply to Marcel Tiede from comment #3) > In ephy-location-entry.c is a binding between "paste_menuitem" and > "paste_and_go_menuitem". The german translation for "_Paste" in epiphany is > different from the translation of GtkEntry. So line 667 in > ephy-location-entry.c is never reached and it fails to create the binding. This is unfortunate. It also looks difficult to avoid. I guess we should just add a warning comment above this line?
(In reply to Marcel Tiede from comment #5) > In which language are you experiencing the problem? Unfortunately i have very few installed, so i can test only german and english for now. Affected: de_DE de_DE.iso88591 de_DE.utf8 Not affected: en_US en_US.iso88591 en_US.utf8 POSIX C
The following fix has been pushed: fc05345 location-entry: Crash nicer if paste menuitem can't be found
Created attachment 338285 [details] [review] location-entry: Crash nicer if paste menuitem can't be found This is really unfortunate design, but I don't see any better way to implement the code, so we'll have to crash if the translation is wrong. Let's give a nice error message at least, and add a warning for the translators, since this is quite a trap otherwise.
So did German translation ever get fixed? We need to file separate bugs against l10n product for each affected translation.
Actually I bet we could just use GTK+'s gettext domain, reopening to investigate how that works....
The following fix has been pushed: 660f461 location-entry: Be robust to paste translation issues
Created attachment 340936 [details] [review] location-entry: Be robust to paste translation issues Don't crash if Epiphany has a different translation than GTK+, just get the translation from GTK+ instead.