After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772881 - Makefile.am uses hardcoded path to pkgconfig
Makefile.am uses hardcoded path to pkgconfig
Status: RESOLVED OBSOLETE
Product: gexiv2
Classification: Other
Component: build
0.10.x
Other FreeBSD
: Normal normal
: ---
Assigned To: Gexiv2 Maintainers
Gexiv2 Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-13 17:14 UTC by Sergey Avseyev
Modified: 2018-05-22 12:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for Makefile.am (730 bytes, patch)
2016-10-13 17:14 UTC, Sergey Avseyev
none Details | Review

Description Sergey Avseyev 2016-10-13 17:14:30 UTC
Created attachment 337654 [details] [review]
Patch for Makefile.am

configure script defines special set variables to be used in Makefile, one of them PKG_CONFIG_LIBDIR, which should be used instead of hardcoded.
Comment 1 Jens Georg 2016-11-16 22:14:19 UTC
Hm. Got any reference? I've never seen it being used like that
Comment 2 Sergey Avseyev 2016-11-16 22:51:44 UTC
Actually `./configure --help` shows it in "Some influential environment variables", as well as in generated `Makefile`.

You can also find it as a recommended way to override default paths in
https://autotools.io/pkgconfig/cross-compiling.html#idm139909974643008

It is defined in `pkg.m4` script of pkg-config:
https://cgit.freedesktop.org/pkg-config/tree/pkg.m4.in#n64
Comment 3 Jens Georg 2016-11-17 07:22:03 UTC
> Actually `./configure --help` shows it in "Some influential environment
> variables", as well as in generated `Makefile`.

  PKG_CONFIG_PATH
              directories to add to pkg-config's search path
  PKG_CONFIG_LIBDIR
              path overriding pkg-config's built-in search path

That's for finding pkg-config files.

> You can also find it as a recommended way to override default paths in
> https://autotools.io/pkgconfig/cross-compiling.html#idm139909974643008

That's helping PKG_CONFIG finding stuff. Installing stuff should just work by setting the DESTDIR to sysroot on make install accordingly.
I don't really see a problem here and none of the other libraries I maintain or 
use does it and they compile in Yocto (or my hand-woven windows env for that matter) quite fine.
Comment 4 Sergey Avseyev 2016-11-17 07:58:28 UTC
Okay. Then my patch is wrong, but still it is not possible to override hardcoded `$(libdir)/pkgconfig` without patching. On FreeBSD *.pc files located at `/usr/local/libdata/pkgconfig`.
Comment 5 GNOME Infrastructure Team 2018-05-22 12:35:12 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gexiv2/issues/21.