After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772826 - cerbero: global name 'platform_str' is not defined
cerbero: global name 'platform_str' is not defined
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
git master
Other Windows
: Normal major
: 1.10.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-10-12 20:51 UTC by Kyle
Modified: 2016-10-31 14:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to resolve bug (807 bytes, patch)
2016-10-18 04:01 UTC, Kyle 		committed Details | Review

Description Kyle 2016-10-12 20:51:37 UTC 
After commit ab27e50941262a79d8975eebd76945f2300c5145 Cerbero is failing to build on a Windows platform with: NameError: global name 'platform_str' is not defined

I believe there is a typo in cerbero/utils/__init__.py line 132. arch is being set above it, so the if should probably read 'if arch in ('x64', 'amd64'):'
Comment 1 Matthew Waters (ystreet00) 2016-10-18 03:21:26 UTC 
Sounds right.  Do you want to provide a patch?
Comment 2 Kyle 2016-10-18 04:01:47 UTC 
Created attachment 337912 [details] [review]
Patch to resolve bug
Comment 3 Matthew Waters (ystreet00) 2016-10-18 05:09:20 UTC 
Thanks!

commit f541eb209f9e253ea96a0acf241605722956e3ef
Author: Kyle Schwarz <kyle.r.schwarz@gmail.com>
Date:   Mon Oct 17 23:57:23 2016 -0400

    cerbero: fix typo in __init__.py
    
    ab27e50941262a79d8975eebd76945f2300c5145 was incomplete and references
    the removed platform_str variable.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=772826