After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772390 - Regression: "b" key in presentation mode doesn't work
Regression: "b" key in presentation mode doesn't work
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
: 795186 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-10-04 07:34 UTC by moriwaka
Modified: 2018-04-12 08:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
EvPresentationView: Redraw widget when updating background css (1.44 KB, patch)
2017-08-19 18:59 UTC, Jonas Hahnfeld 		committed Details | Review

Description moriwaka 2016-10-04 07:34:43 UTC 
"b" key in presentation mode doesn't work.  But "w" key is works.

I found some odd behaviour as following
1. go presentation mode
2. push "b" doesn't work
3. push "w" white out screen
4. push "b" black out screen
5. push "b" again, doesn't work

https://bugzilla.gnome.org/show_bug.cgi?id=765557 may be related with this problem.
Comment 1 Jonas Hahnfeld 2017-08-19 18:59:21 UTC 
Created attachment 357986 [details] [review]
EvPresentationView: Redraw widget when updating background  css

I think the widget needs to be redrawn when switching the CSS classes. This patch fixes the problem for me on current git master.
Comment 2 José Aliste 2018-03-03 04:22:06 UTC 
Review of attachment 357986 [details] [review]:

Looks almost good. Thanks! I committed a slightly different version to git master.

::: libview/ev-view-presentation.c
@@ +171,1 @@
 #endif

this part is not needed. Adding a css class will invalidate the widget and queue a redraw.
Comment 3 José Aliste 2018-03-03 04:22:34 UTC 
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.
Comment 4 André Klapper 2018-04-12 08:30:24 UTC 
*** Bug 795186 has been marked as a duplicate of this bug. ***