After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 772220 - [PATCH] Add XPathContext interface to DomElement, just after GLib.Object declaration
[PATCH] Add XPathContext interface to DomElement, just after GLib.Object decl...
Status: RESOLVED FIXED
Product: gxml
Classification: Other
Component: XPath
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GXml maintainer(s)
GXml maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-09-30 03:14 UTC by Yannick Inizan
Modified: 2016-10-03 23:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] Add XPathContext interface to DomElement, just after GLib.Object declaration (3.51 KB, patch)
2016-09-30 03:14 UTC, Yannick Inizan 		reviewed Details | Review

Description Yannick Inizan 2016-09-30 03:14:39 UTC 
Created attachment 336575 [details] [review]
[PATCH] Add XPathContext interface to DomElement, just after GLib.Object declaration

we have this bug at execution :

``[GLib-GObject] cannot add interface type 'GXmlXPathContext' to type 'GXmlGElement' which does not conform to prerequisite...``

to resolve this, add XPathContext interface to DomElement, after 'GLib.Object' declaration.

this patch provides also test for XPath.
Comment 1 Daniel Espinosa 2016-10-01 05:03:17 UTC 
Review of attachment 336575 [details] [review]:

Your patch fails.

I try to push it as is, but unable. Take the opportunity to comment you:

Please don't touch DOM interfaces, if you have any issue should be done in XPath interfaces and implementation.

Please rework this patch and make sure it will work. I can change any thing later if you wish.
Comment 2 Daniel Espinosa 2016-10-03 23:50:27 UTC 
I'm pushed all your work upstream. Made some fixes and now Unit tests are in place.

Please feel free to add more tests in order to ensure it works as expected.