After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771202 - GtkCellRendererProgress uses different/fewer CSS classes than GtkProgressBar
GtkCellRendererProgress uses different/fewer CSS classes than GtkProgressBar
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Themes
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-09-10 18:30 UTC by mod-oss
Modified: 2018-05-02 17:30 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description mod-oss 2016-09-10 18:30:49 UTC
In gtk_cell_renderer_progress_render, the .trough style class is applied when rendering the trough, and the .progressbar style class is applied when rendering the actual progress (not the trough), but the usage of these does not match that of GtkProgressBar. GtkProgressBar applies .progressbar to all its rendering, and .trough and .progress (no "bar") to the subcomponents. In the cell renderer, the .progressbar class is only added to the actual progress portion of the bar, and .progress is never applied. 

GtkProgressBar also applies one of the .left/.right/.top/.bottom classes while the cell renderer does not.

In addition, no .horizontal/.vertical style class is set for the orientation of GtkCellRendererProgress, which makes theming them properly in all cases virtually impossible.
Comment 1 Daniel Boles 2018-03-31 11:21:29 UTC
"wrong" is a bit subjective, in that it assumes that GtkCellRendererProgress should use the same classes as GtkProgressBar, an assumption that isn't intended by the current state of our themes. I think this needs input from the theme designers on whether they would want this, then the widget could be updated to match - but probably not in GTK+ 3, since that would break third-party themes.

Besides, without any example code or screenshots, it's not very clear that there are concrete problems, besides the lack of symmetry. Some clarity there would be great.
Comment 2 GNOME Infrastructure Team 2018-05-02 17:30:25 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/668.