After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770990 - New Plugin: Add GStreamer plugin for Intel's MediaSDK
New Plugin: Add GStreamer plugin for Intel's MediaSDK
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.11.1
Assigned To: Josep Torra Valles
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-07 08:19 UTC by sreerenj
Modified: 2016-11-14 14:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH gst-plugins-bad 1/6] msdk: Create plugin for Intel's Media SDK (89.88 KB, patch)
2016-11-03 20:23 UTC, Scott D Phillips
none Details | Review
[PATCH gst-plugins-bad 2/6] msdk: add to build (4.75 KB, patch)
2016-11-03 20:24 UTC, Scott D Phillips
committed Details | Review
[PATCH gst-plugins-bad 3/6] msdk: Width and Height need to be integer multiples of 32 (1.61 KB, patch)
2016-11-03 20:24 UTC, Scott D Phillips
committed Details | Review
[PATCH gst-plugins-bad 4/6] msdk: load plugins in h265 and vp8 init (2.80 KB, patch)
2016-11-03 20:25 UTC, Scott D Phillips
committed Details | Review
[PATCH gst-plugins-bad 5/6] meson: add build files for msdk (2.00 KB, patch)
2016-11-03 20:25 UTC, Scott D Phillips
committed Details | Review
[PATCH gst-plugins-bad 6/6] msdk: Initial windows build support (23.02 KB, patch)
2016-11-03 20:25 UTC, Scott D Phillips
none Details | Review
[PATCH gst-plugins-bad v2 6/6] msdk: Initial windows build support (23.21 KB, patch)
2016-11-03 20:46 UTC, Scott D Phillips
none Details | Review
[PATCH gst-plugins-bad v2 1/6] msdk: Create plugin for Intel's Media SDK (89.71 KB, patch)
2016-11-03 22:02 UTC, Scott D Phillips
committed Details | Review
[PATCH gst-plugins-bad v3 6/6] msdk: Initial windows build support (22.96 KB, patch)
2016-11-07 17:31 UTC, Scott D Phillips
committed Details | Review

Description sreerenj 2016-09-07 08:19:02 UTC
Intel's Media SDK is a cross platfrom API for developing media applications. It provides hardware acceleration for video decoding, encoding and post-processing in Intel platfroms.

There is a gstreamer plugins already out under BSD3 license,
https://github.com/Oblong/gst-msdk

This is a proposal for merging gst-msdk to gst-plugins-bad.
Comment 1 Tim-Philipp Müller 2016-09-07 08:25:10 UTC
Yep, let's merge after 1.10 is out. Meant to do that already, but missed the window, sorry!
Comment 2 Scott D Phillips 2016-09-14 15:57:37 UTC
I've got Oblong's plugin formulated as patches here:

https://github.com/scott-d-phillips/gst-plugins-bad

I'll also do a little squashing there.
Comment 3 Scott D Phillips 2016-11-03 20:23:49 UTC
Created attachment 339069 [details] [review]
[PATCH gst-plugins-bad 1/6] msdk: Create plugin for Intel's Media SDK
Comment 4 Scott D Phillips 2016-11-03 20:24:07 UTC
Created attachment 339070 [details] [review]
[PATCH gst-plugins-bad 2/6] msdk: add to build
Comment 5 Scott D Phillips 2016-11-03 20:24:38 UTC
Created attachment 339071 [details] [review]
[PATCH gst-plugins-bad 3/6] msdk: Width and Height need to be integer multiples of 32
Comment 6 Scott D Phillips 2016-11-03 20:25:04 UTC
Created attachment 339072 [details] [review]
[PATCH gst-plugins-bad 4/6] msdk: load plugins in h265 and vp8 init
Comment 7 Scott D Phillips 2016-11-03 20:25:23 UTC
Created attachment 339073 [details] [review]
[PATCH gst-plugins-bad 5/6] meson: add build files for msdk
Comment 8 Scott D Phillips 2016-11-03 20:25:35 UTC
Created attachment 339074 [details] [review]
[PATCH gst-plugins-bad 6/6] msdk: Initial windows build support
Comment 9 Scott D Phillips 2016-11-03 20:46:01 UTC
Created attachment 339075 [details] [review]
[PATCH gst-plugins-bad v2 6/6] msdk: Initial windows build support

Changes from v1:
 Messed up moving `#include <unistd.h>` around in first patch.
Comment 10 Scott D Phillips 2016-11-03 22:02:33 UTC
Created attachment 339082 [details] [review]
[PATCH gst-plugins-bad v2 1/6] msdk: Create plugin for Intel's Media SDK

Changes since v1:           
 Removed unneeded section which was conditional on
 GST_CHECK_VERSION (1,8,0).
Comment 11 Josep Torra Valles 2016-11-06 16:46:57 UTC
Review of attachment 339075 [details] [review]:

Add msdk.c into Makefile.am too.

::: sys/msdk/msdk.c
@@ +31,3 @@
+
+#include "msdk.h"
+

Add the following for the session functions moved here.

GST_DEBUG_CATEGORY_EXTERN (gst_msdkenc_debug);
#define GST_CAT_DEFAULT gst_msdkenc_debug

@@ +182,3 @@
+
+void
+_msdk_close_session (mfxSession session)

Do not prefix with underscore.

@@ +195,3 @@
+
+mfxSession
+_msdk_open_session (gboolean hardware)

Do not prefix with underscore.
Comment 12 Josep Torra Valles 2016-11-06 16:46:58 UTC
Review of attachment 339075 [details] [review]:

Add msdk.c into Makefile.am too.

::: sys/msdk/msdk.c
@@ +31,3 @@
+
+#include "msdk.h"
+

Add the following for the session functions moved here.

GST_DEBUG_CATEGORY_EXTERN (gst_msdkenc_debug);
#define GST_CAT_DEFAULT gst_msdkenc_debug

@@ +182,3 @@
+
+void
+_msdk_close_session (mfxSession session)

Do not prefix with underscore.

@@ +195,3 @@
+
+mfxSession
+_msdk_open_session (gboolean hardware)

Do not prefix with underscore.
Comment 13 Scott D Phillips 2016-11-07 17:31:53 UTC
Created attachment 339264 [details] [review]
[PATCH gst-plugins-bad v3 6/6] msdk: Initial windows build support

Changes from v2:
 Removed underscore prefix from msdk_{open,close}_session
 Added msdk.c to Makefile.am
Comment 14 Josep Torra Valles 2016-11-14 14:44:03 UTC
Comment on attachment 339082 [details] [review]
[PATCH gst-plugins-bad v2 1/6] msdk: Create plugin for Intel's Media SDK

commit 7d68d40239aa4162ff58fa63dad4baef8edc97c5
Author: Josep Torra <jtorra@oblong.com>
Date:   Fri Apr 1 19:25:25 2016 +0200

    msdk: Create plugin for Intel's Media SDK
    
    [scott.d.phillips@intel.com: gst-indent *.c *.h]
    [scott.d.phillips@intel.com: link with libva at build time]
    [scott.d.phillips@intel.com: remove unused includes]
    [scott.d.phillips@intel.com: Update README]
    
    https://bugzilla.gnome.org/show_bug.cgi?id=770990
Comment 15 Josep Torra Valles 2016-11-14 14:44:36 UTC
Comment on attachment 339070 [details] [review]
[PATCH gst-plugins-bad 2/6] msdk: add to build

commit 22551a42cc0bf31485b2b19abfe2ebadcffbfaf9
Author: Scott D Phillips <scott.d.phillips@intel.com>
Date:   Fri Sep 9 15:43:25 2016 -0700

    msdk: add to build
    
    https://bugzilla.gnome.org/show_bug.cgi?id=770990
Comment 16 Josep Torra Valles 2016-11-14 14:45:14 UTC
Comment on attachment 339071 [details] [review]
[PATCH gst-plugins-bad 3/6] msdk: Width and Height need to be integer multiples of 32

commit 2905a7e33eb5618b5b505414b595bd59441fb171
Author: Scott D Phillips <scott.d.phillips@intel.com>
Date:   Tue Sep 27 14:17:49 2016 -0700

    msdk: Width and Height need to be integer multiples of 32
    
    https://bugzilla.gnome.org/show_bug.cgi?id=770990
Comment 17 Josep Torra Valles 2016-11-14 14:49:30 UTC
Comment on attachment 339072 [details] [review]
[PATCH gst-plugins-bad 4/6] msdk: load plugins in h265 and vp8 init

commit 35f76fc33ae0c458505c8455dbac42f7837e0365
Author: Scott D Phillips <scott.d.phillips@intel.com>
Date:   Tue Sep 27 14:21:34 2016 -0700

    msdk: load plugins in h265 and vp8 init
    
    https://bugzilla.gnome.org/show_bug.cgi?id=770990
Comment 18 Josep Torra Valles 2016-11-14 14:50:00 UTC
Comment on attachment 339073 [details] [review]
[PATCH gst-plugins-bad 5/6] meson: add build files for msdk

commit 8949c12aafbbc5e3e2f49abd873690fb76091b95
Author: Scott D Phillips <scott.d.phillips@intel.com>
Date:   Thu Oct 13 14:30:43 2016 -0700

    meson: add build files for msdk
    
    https://bugzilla.gnome.org/show_bug.cgi?id=770990
Comment 19 Josep Torra Valles 2016-11-14 14:50:30 UTC
Comment on attachment 339264 [details] [review]
[PATCH gst-plugins-bad v3 6/6] msdk: Initial windows build support

commit 71df82db63ff9a780162d9e8eea985b2172021e0
Author: Scott D Phillips <scott.d.phillips@intel.com>
Date:   Thu Nov 3 10:47:00 2016 -0700

    msdk: Initial windows build support
    
    https://bugzilla.gnome.org/show_bug.cgi?id=770990