After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770842 - Guard against printf("%s", NULL) that can be hit on exit and in the open dialog.
Guard against printf("%s", NULL) that can be hit on exit and in the open dialog.
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: General
2.8.18
Other OpenBSD
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2016-09-04 09:30 UTC by Giovanni Bechis
Modified: 2018-05-24 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Guard against printf("%s", NULL) (1.47 KB, patch)
2016-09-04 09:30 UTC, Giovanni Bechis 		none Details | Review

Description Giovanni Bechis 2016-09-04 09:30:58 UTC 
Created attachment 334741 [details] [review]
Guard against printf("%s", NULL)

On exit and on the open dialog printf("%s", ..) could have a NULL parameter.
Attached patch.
 Giovanni
Comment 1 Michael Natterer 2016-09-04 19:17:07 UTC 
This patch protects against the identifier quark being 0, how can this
happen at all? Seems like this is safety against a bug happening
somewhere else.

Did this actually happen to you and did you figure why?
Comment 2 Michael Schumacher 2016-10-09 22:22:54 UTC 
Giovanni, can you answer the question in comment 1?
Comment 3 Giovanni Bechis 2016-10-13 08:26:01 UTC 
It happens to me as well, I will try to debug it asap.
 Giovanni
Comment 4 Michael Schumacher 2016-12-08 09:03:07 UTC 
Did you figure out why this happens?
Comment 5 Michael Schumacher 2017-02-13 20:55:54 UTC 
Giovanni, any news?
Comment 6 Giovanni Bechis 2017-02-17 17:58:33 UTC 
It seems to have disappeared after upgrading to some gtk+2 version, I am running with gtk+2.24.31 and there is no more warning.
 Giovanni
Comment 7 Michael Natterer 2017-02-17 18:03:49 UTC 
Thanks for checking!
Comment 8 Giovanni Bechis 2017-02-18 11:03:40 UTC 
I was wrong, sorry.
The warning is still there and us due to at least a glib function:

https://github.com/GNOME/glib/blob/master/glib/gstring.c#L1132
Comment 9 Michael Natterer 2018-01-01 23:07:46 UTC 
There is some weird shit going on with tags, we should look into this
for 2.10.x at least.
Comment 10 GNOME Infrastructure Team 2018-05-24 16:50:57 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/953.