After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770049 - vtdec: missing systemstream=false in mpeg decoder caps
vtdec: missing systemstream=false in mpeg decoder caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal normal
: 1.9.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-17 18:01 UTC by Matej Knopp
Modified: 2016-08-22 19:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (913 bytes, patch)
2016-08-17 18:01 UTC, Matej Knopp 		committed Details | Review

Description Matej Knopp 2016-08-17 18:01:00 UTC 
Created attachment 333514 [details] [review]
Patch

Without systemstream=false the decoder may be instantiated instead of demuxer
Comment 1 Tim-Philipp Müller 2016-08-21 16:30:00 UTC 
Looks good. I wonder if it also needs/wants parsed=true ?
Comment 2 Matej Knopp 2016-08-22 18:35:36 UTC 
Video toolbox expects entire frame in VTDecompressionSessionDecodeFrame so I'd suppose so.
Comment 3 Tim-Philipp Müller 2016-08-22 19:26:05 UTC 
Ok, thanks! Let's try this then:

 commit 26c7ca4c24fdad9b599b7c68adee036e20c07ef1
 Author: Matej Knopp <matej.knopp@gmail.com>
 Date:   Wed Aug 17 19:59:17 2016 +0200

    vtdec: fix MPEG-2 video caps
    
    Add systemstream=false to caps, otherwise the decoder
    may be picked for MPEG-PS files. Also parsed=true,
    as video toolbox expects entire frame in
    VTDecompressionSessionDecodeFrame.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=770049