After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768644 - Cursor themes leak into Icons themes dropdown menu
Cursor themes leak into Icons themes dropdown menu
Status: RESOLVED OBSOLETE
Product: gnome-tweak-tool
Classification: Applications
Component: general
3.26.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-07-11 04:36 UTC by Ricardo Ramos
Modified: 2018-01-24 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Gnome-tweak-tool screenshot (44.97 KB, image/png)
2016-07-11 04:36 UTC, Ricardo Ramos
  Details
Patch to resolve the bug. (1.01 KB, patch)
2017-03-04 01:00 UTC, Gianni Lerro
reviewed Details | Review

Description Ricardo Ramos 2016-07-11 04:36:21 UTC
Created attachment 331175 [details]
Gnome-tweak-tool screenshot

If I remember correctly, when we add a new cursor theme into .icons folder in home folder or when it's installed system-wide it used to appear only in its corresponding dropdown menu, but now the same theme name leaks into icon dropdown menu as well; the attached picture shows I added a cursor theme called Breeze_snow but also appears in icon dropdown menu, if I select it nothing happens, the icon set remains the same because there isn't a real icon theme in there but a cursor theme which works as expected.
Comment 1 Gianni Lerro 2017-03-04 01:00:51 UTC
Created attachment 347180 [details] [review]
Patch to resolve the bug.

Hi,
I have the same problem, and I have patched it.
Comment 2 Rui Matos 2017-03-06 15:36:18 UTC
Review of attachment 347180 [details] [review]:

Thanks for looking at this, but I'm afraid there's no g-t-t bug here. It's valid to have a theme that is both an icons theme and a cursors theme.
Comment 3 Rui Matos 2017-03-06 15:38:43 UTC
(In reply to Ricardo Ramos from comment #0)
> If I remember correctly, when we add a new cursor theme into .icons folder
> in home folder or when it's installed system-wide it used to appear only in
> its corresponding dropdown menu, but now the same theme name leaks into icon
> dropdown menu as well; the attached picture shows I added a cursor theme
> called Breeze_snow but also appears in icon dropdown menu, if I select it
> nothing happens, the icon set remains the same because there isn't a real
> icon theme in there but a cursor theme which works as expected.

Does the Breeze_snow directory contain an index.theme file? If it does and doesn't actually contain icons then it's a theme issue.
Comment 4 Ricardo Ramos 2017-03-06 15:51:12 UTC
(In reply to Rui Matos from comment #3)

> Does the Breeze_snow directory contain an index.theme file? If it does and
> doesn't actually contain icons then it's a theme issue.

I don't know, If you can't fix this then close the report, I don't have time for this.
Comment 5 Gianni Lerro 2017-03-07 00:30:27 UTC
The Breeze_snow cursor theme have an index.theme, what is the correct .theme file for cursors? I didn't find a specification on freedesktop.org, the man page of Xcursor says "If necessary, Xcursor also looks for a "index.theme" file in  each  theme  directory  to  find  inherited themes and searches along the path for those themes as well.". Most of the cursors theme i found on internet contain an index.theme.
Comment 6 Rui Matos 2017-03-07 12:02:59 UTC
(In reply to Gianni Lerro from comment #5)
> The Breeze_snow cursor theme have an index.theme, what is the correct .theme
> file for cursors?

There is no .theme file for cursor only themes.

> I didn't find a specification on freedesktop.org, the man
> page of Xcursor says "If necessary, Xcursor also looks for a "index.theme"
> file in  each  theme  directory  to  find  inherited themes and searches
> along the path for those themes as well.".

Right. That man page, also says, right before that quote:

"Xcursor  (mostly)  follows  the  freedesktop.org spec for theming icons.  The default search path it uses is ~/.icons, /usr/share/icons, /usr/share/pixmaps.  Within each of these directories, it searches for a  directory using the theme name.  Within the theme directory, it looks for cursor files in the 'cursors' subdirectory.  It uses the first cursor file found along  the path."

which, to me, means that the only requirement for cursor themes is to have a 'cursors' directory under a theme named parent directory which itself must be in one of those toplevel 'icons' directories.

> Most of the cursors theme i found
> on internet contain an index.theme.

That doesn't means it's required, I'm afraid.

What I think we can improve here is the icon theme filter to only include theme directories which have at least one subdirectory that's not 'cursors'.
Comment 7 Gianni Lerro 2017-03-07 21:29:00 UTC
Ok,
Thanks for the exhaustive explaination.

For me the improvement that you want to make is very good, and solves the problem.
For a most clear and clean user interface.

(In reply to Rui Matos from comment #6)
> What I think we can improve here is the icon theme filter to only include
> theme directories which have at least one subdirectory that's not 'cursors'.
Comment 8 GNOME Infrastructure Team 2018-01-24 15:15:45 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-tweaks/issues/72.