After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768553 - Configure check for OpenGL is wrong on OS X.
Configure check for OpenGL is wrong on OS X.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other Mac OS
: Normal normal
: 1.9.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-08 08:09 UTC by Petros
Modified: 2016-07-11 01:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gl/build: fix configure when --enable-cocoa is passed on OS X (917 bytes, patch)
2016-07-08 09:05 UTC, Matthew Waters (ystreet00)
committed Details | Review

Description Petros 2016-07-08 08:09:52 UTC
Currently the configure step when building gst-plugins-bad under OS X is looking in the wrong place for detecting OpenGL. This results in OpenGL not being found although present on the system.

The check on OS X should test against the OpenGL framework and look for OpenGL/gl.h instead of GL/gl.h which is currently used in the configure.ac file.

Tested on OS X El Capitan 10.11.2
Comment 1 Matthew Waters (ystreet00) 2016-07-08 08:36:48 UTC
It already does.

https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/configure.ac#n1047

If you're having problems with configuring OpenGL on OS X, we at least need your config.log from a configure run.
Comment 2 Sebastian Dröge (slomo) 2016-07-08 08:41:01 UTC
There are a few checks with GL/gl.h here for example, which also happen for OSX/iOS: https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/configure.ac#n707
Comment 3 Matthew Waters (ystreet00) 2016-07-08 08:42:15 UTC
Yes, but they don't matter on OS X/iOS...
Comment 4 Petros 2016-07-08 08:45:31 UTC
For me the check that Sebastian linked fails if I run :

./configure --enable-opengl=yes --enable-cocoa

For a config output pls see the log here :

http://gstreamer-devel.966125.n4.nabble.com/file/n4678493/config.log
Comment 5 Matthew Waters (ystreet00) 2016-07-08 08:49:03 UTC
Ah, take --enable-cocoa=yes out of your configure options.  There's a bug in ./configure on OS X with that.
Comment 6 Matthew Waters (ystreet00) 2016-07-08 09:05:53 UTC
Created attachment 331059 [details] [review]
gl/build: fix configure when --enable-cocoa is passed on OS X

Completely untested patch that should fix your issue with --enable-cocoa.
Comment 7 Petros 2016-07-08 09:07:37 UTC
Cool, thanks a lot.

I ll give it a try when I have a minute and I will report back here.
Comment 8 Petros 2016-07-08 14:24:39 UTC
Can confirm that with this patch the configure step executes properly when run with the above mentioned flags on my machine.
Comment 9 Matthew Waters (ystreet00) 2016-07-11 01:30:38 UTC
commit 2ae16c2f685ab81916526a65969d821c4fa3322e
Author: Matthew Waters <matthew@centricular.com>
Date:   Fri Jul 8 19:03:06 2016 +1000

    gl/build: fix configure when --enable-cocoa is passed on OS X
    
    https://bugzilla.gnome.org/show_bug.cgi?id=768553