After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767182 - TheGamesDB to resolve for games only
TheGamesDB to resolve for games only
Status: RESOLVED OBSOLETE
Product: grilo
Classification: Other
Component: lua
unspecified
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2016-06-02 21:28 UTC by Victor Toso
Modified: 2018-09-24 09:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Victor Toso 2016-06-02 21:28:28 UTC 
The source table should use supported_media = "game" to only resolve for this specific type of media otherwise the source could be setting metadata for music and videos.

From a quick look in grl-lua-factory.c, we would need to improve GrlSupportedMedia enum in core to have games or a generic-type... but a generic type does not really solve the problem as we can have the bug between generic types.

Ideas?
Comment 1 Bastien Nocera 2016-06-02 21:39:43 UTC 
It's matched when the supported_media is none of video, audio or photo. Did you find a bug, or were you just wondering whether we should extend that type?
Comment 2 Victor Toso 2016-06-03 07:10:15 UTC 
(In reply to Bastien Nocera from comment #1)
> It's matched when the supported_media is none of video, audio or photo. Did
> you find a bug, or were you just wondering whether we should extend that
> type?

Both :)

(1) Bug: using grilo-test-ui-0.3, I went for iTunes source and then TED Radio Hour - NPR and got this:

artist: NPR
description: Technician Ted is an Action game, developed and published by Hewson,  which was released in Europe in 1984.
external-url: http://www.gamefaqs.com/cpc/931187-technician-ted
genre: Action
...
title: TED Radio Hour - NPR
source: grl-itunes-podcast

(2) In case we have different media-types like "Document" and "Game" this would still be a problem... I think we need some solution in the core.
Comment 3 GNOME Infrastructure Team 2018-09-24 09:43:54 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/grilo/issues/89.