After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766331 - data: Add a way for gnome-user-share to be started via user systemd
data: Add a way for gnome-user-share to be started via user systemd
Status: RESOLVED FIXED
Product: gnome-user-share
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-user-share maintainers
gnome-user-share maintainers
Depends on:
Blocks: 766329
 
 
Reported: 2016-05-12 14:01 UTC by Bastien Nocera
Modified: 2016-08-30 10:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
data: Add a way for gnome-user-share to be started via user systemd (3.02 KB, patch)
2016-05-12 14:01 UTC, Bastien Nocera
none Details | Review
data: Add a way for gnome-user-share to be started via user systemd (3.62 KB, patch)
2016-05-13 08:48 UTC, Bastien Nocera
none Details | Review
data: Add a way for gnome-user-share to be started via user systemd (3.62 KB, patch)
2016-08-30 10:33 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2016-05-12 14:01:29 UTC
.
Comment 1 Bastien Nocera 2016-05-12 14:01:34 UTC
Created attachment 327714 [details] [review]
data: Add a way for gnome-user-share to be started via user systemd

This will allow better tracking of whether gnome-user-share-webdav is
running, ensuring that even if the manager to enable/disable its startup
(gnome-settings-daemon) crashes and needs to restart, its status is still
available by querying the user systemd.
Comment 2 Bastien Nocera 2016-05-13 08:48:58 UTC
Created attachment 327766 [details] [review]
data: Add a way for gnome-user-share to be started via user systemd

This will allow better tracking of whether gnome-user-share-webdav is
running, ensuring that even if the manager to enable/disable its startup
(gnome-settings-daemon) crashes and needs to restart, its status is still
available by querying the user systemd.
Comment 3 Ray Strode [halfline] 2016-07-28 15:40:23 UTC
Review of attachment 327766 [details] [review]:

pretty sure this needs all the same changes as vino in bug 766330
Comment 4 Bastien Nocera 2016-08-30 10:33:07 UTC
Created attachment 334426 [details] [review]
data: Add a way for gnome-user-share to be started via user systemd

This will allow better tracking of whether gnome-user-share-webdav is
running, ensuring that even if the manager to enable/disable its startup
(gnome-settings-daemon) crashes and needs to restart, its status is still
available by querying the user systemd.
Comment 5 Bastien Nocera 2016-08-30 10:35:29 UTC
(In reply to Ray Strode [halfline] from comment #3)
> Review of attachment 327766 [details] [review] [review]:
> 
> pretty sure this needs all the same changes as vino in bug 766330

The only change needed was the Makefile.am one. It's not a d-bus service that can be auto-started, so the first rygel patch didn't apply, and I don't want it to be started automatically in the session either, so the second patch wasn't needed.
Comment 6 Bastien Nocera 2016-08-30 10:41:00 UTC
(In reply to Bastien Nocera from comment #5)
> (In reply to Ray Strode [halfline] from comment #3)
> > Review of attachment 327766 [details] [review] [review] [review]:
> > 
> > pretty sure this needs all the same changes as vino in bug 766330
> 
> The only change needed was the Makefile.am one. It's not a d-bus service
> that can be auto-started, so the first rygel patch didn't apply, and I don't
> want it to be started automatically in the session either, so the second
> patch wasn't needed.

s/vino/rygel/

The only relevant change in the vino bug was the PKG_CHECK_EXISTS() call.