After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766229 - appsrc: Add duration property for providing a duration in TIME format
appsrc: Add duration property for providing a duration in TIME format
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-10 13:44 UTC by Sebastian Dröge (slomo)
Modified: 2017-08-12 15:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
appsrc: Add duration property for providing a duration in TIME format (6.33 KB, patch)
2016-05-10 13:44 UTC, Sebastian Dröge (slomo) 		none Details | Review
appsrc: Add duration property for providing a duration in TIME format (6.40 KB, patch)
2016-05-10 13:48 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2016-05-10 13:44:24 UTC 
See commit message.
Comment 1 Sebastian Dröge (slomo) 2016-05-10 13:44:28 UTC 
Created attachment 327592 [details] [review]
appsrc: Add duration property for providing a duration in TIME format
Comment 2 Sebastian Dröge (slomo) 2016-05-10 13:48:44 UTC 
Created attachment 327594 [details] [review]
appsrc: Add duration property for providing a duration in TIME format
Comment 3 Sebastian Dröge (slomo) 2016-05-10 13:54:50 UTC 
Attachment 327594 [details] pushed as dc8120f - appsrc: Add duration property for providing a duration in TIME format
Comment 4 Philippe Normand 2017-08-12 14:51:16 UTC 
Review of attachment 327594 [details] [review]:

::: gst-libs/gst/app/gstappsrc.c
@@ +960,3 @@
         res = TRUE;
+      } else if (format == GST_FORMAT_TIME) {
+        gst_query_set_duration (query, format, priv->duration);

Shouldn't we check the duration was set to a valid value here? At least different from GST_CLOCK_TIME_NONE?
Comment 5 Philippe Normand 2017-08-12 15:22:51 UTC 
See https://bugzilla.gnome.org/show_bug.cgi?id=786200 :)