After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765612 - Fix "format not a string literal" warning
Fix "format not a string literal" warning
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-26 13:38 UTC by Bastien Nocera
Modified: 2016-05-20 20:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GladeGtkFlowBox: Fix "format not a string literal" warning (2.37 KB, patch)
2016-04-26 13:38 UTC, Bastien Nocera
none Details | Review
GladeGtkGrid: Fix "format not a string literal" warning (5.93 KB, patch)
2016-04-26 13:38 UTC, Bastien Nocera
none Details | Review
GladeGtkListBox: Fix "format not a string literal" warning (2.36 KB, patch)
2016-04-26 13:38 UTC, Bastien Nocera
none Details | Review
GladeGtkNotebook: Fix "format not a string literal" warning (6.32 KB, patch)
2016-04-26 13:38 UTC, Bastien Nocera
none Details | Review
GladeGtkTable: Fix "format not a string literal" warning (5.82 KB, patch)
2016-04-26 13:38 UTC, Bastien Nocera
none Details | Review

Description Bastien Nocera 2016-04-26 13:38:10 UTC
.
Comment 1 Bastien Nocera 2016-04-26 13:38:15 UTC
Created attachment 326765 [details] [review]
GladeGtkFlowBox: Fix "format not a string literal" warning

glade-gtk-flow-box.c: In function ‘glade_gtk_flowbox_child_insert_action’:
glade-gtk-flow-box.c:205:3: error: format not a string literal, argument types not checked [-Werror=format-nonliteral]
   glade_command_push_group (group_format, glade_widget_get_name (parent));
   ^~~~~~~~~~~~~~~~~~~~~~~~
Comment 2 Bastien Nocera 2016-04-26 13:38:21 UTC
Created attachment 326766 [details] [review]
GladeGtkGrid: Fix "format not a string literal" warning

glade-gtk-grid.c: In function ‘glade_gtk_grid_child_insert_remove_action’:
glade-gtk-grid.c:496:3: error: format not a string literal, argument types not checked [-Werror=format-nonliteral]
   glade_command_push_group (group_format, glade_widget_get_name (parent));
   ^~~~~~~~~~~~~~~~~~~~~~~~
Comment 3 Bastien Nocera 2016-04-26 13:38:26 UTC
Created attachment 326767 [details] [review]
GladeGtkListBox: Fix "format not a string literal" warning

glade-gtk-list-box.c: In function ‘glade_gtk_listbox_child_insert_action’:
glade-gtk-list-box.c:208:3: error: format not a string literal, argument types not checked [-Werror=format-nonliteral]
   glade_command_push_group (group_format, glade_widget_get_name (parent));
   ^~~~~~~~~~~~~~~~~~~~~~~~
Comment 4 Bastien Nocera 2016-04-26 13:38:30 UTC
Created attachment 326768 [details] [review]
GladeGtkNotebook: Fix "format not a string literal" warning

glade-gtk-notebook.c: In function ‘glade_gtk_box_notebook_child_insert_remove_action’:
glade-gtk-notebook.c:988:3: error: format not a string literal, argument types not checked [-Werror=format-nonliteral]
   glade_command_push_group (group_format, glade_widget_get_name (parent));
   ^~~~~~~~~~~~~~~~~~~~~~~~
Comment 5 Bastien Nocera 2016-04-26 13:38:35 UTC
Created attachment 326769 [details] [review]
GladeGtkTable: Fix "format not a string literal" warning

glade-gtk-table.c: In function ‘glade_gtk_table_child_insert_remove_action’:
glade-gtk-table.c:527:3: error: format not a string literal, argument types not checked [-Werror=format-nonliteral]
   glade_command_push_group (group_format, glade_widget_get_name (parent));
   ^~~~~~~~~~~~~~~~~~~~~~~~
Comment 6 Juan Pablo Ugarte 2016-05-20 20:25:48 UTC
Thanks for the patches Bastien

I pushed them to master and glade-3-20 except for the Notebook one because it changes a symbol which should probably be private but it is not :S