After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763329 - Thumbnails don't reflect edited state
Thumbnails don't reflect edited state
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.19.x
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on: 690255
Blocks:
 
 
Reported: 2016-03-08 15:50 UTC by Allan Day
Modified: 2017-06-30 18:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
thumbnailer-dbus: Add a Cancel method to support cancellation (1.31 KB, patch)
2017-02-23 09:38 UTC, Debarshi Ray
committed Details | Review
thumbnailer: Use a GCancellable when handling GenerateThumbnail (2.06 KB, patch)
2017-02-23 09:38 UTC, Debarshi Ray
committed Details | Review
thumbnailer: Track the invocations and cancellables of ongoing jobs (2.15 KB, patch)
2017-02-23 09:39 UTC, Debarshi Ray
committed Details | Review
thumbnailer: Implement cancellation (3.24 KB, patch)
2017-02-23 09:39 UTC, Debarshi Ray
committed Details | Review
thumbnail-factory: Implement cancellation (3.28 KB, patch)
2017-02-23 09:39 UTC, Debarshi Ray
committed Details | Review
base-item: Use a GCancellable when creating a thumbnail (2.16 KB, patch)
2017-02-23 09:40 UTC, Debarshi Ray
committed Details | Review
base-item: Delete the thumbnail if create_thumbnail was cancelled (1.92 KB, patch)
2017-02-23 09:40 UTC, Debarshi Ray
committed Details | Review
base-item: Refresh the thumbnail whenever the pipeline is saved (3.31 KB, patch)
2017-02-23 09:40 UTC, Debarshi Ray
committed Details | Review
thumbnailer: Fix typo and complete the right D-Bus call (1.14 KB, patch)
2017-06-30 18:16 UTC, Debarshi Ray
committed Details | Review

Description Allan Day 2016-03-08 15:50:45 UTC
If you edit a photo, the thumbnail isn't updated - it shows the original image rather than the edited version.
Comment 1 Debarshi Ray 2016-03-09 13:09:21 UTC
This is something that I am targeting for 3.20.1, not 3.20.0.

We will have to replace the current thumbnail code based on GIO and gnome-desktop with our own custom thumbnail creation and query code. The issue is that the platform's builtin thumbnail API is not meant to handle source-file-plus-some-modifications, which is what we have. We could have used gnome-desktop to create the thumbnails and then applied the modifications on top of it inside the application, but that won't work very well if you consider crops.

Darktable, which has a similar data model, does the same [1]. I haven't yet investigated what shotwell does.

Either way, I am not comfortable sneaking such a big change during the freezes.

[1] https://www.darktable.org/usermanual/ch02s02s03.html.php
Comment 2 Debarshi Ray 2016-04-04 15:26:55 UTC
Shotwell, also, has its own thumbnail cache in ~/.cache/shotwell/thumbs/ There is some background literature for those who are interested: https://wiki.gnome.org/Apps/Shotwell/Architecture/Caching
Comment 3 Debarshi Ray 2017-02-15 10:21:59 UTC
(In reply to Debarshi Ray from comment #1)
> We will have to replace the current thumbnail code based on GIO and
> gnome-desktop with our own custom thumbnail creation and query code. The
> issue is that the platform's builtin thumbnail API is not meant to handle
> source-file-plus-some-modifications, which is what we have. We could have
> used gnome-desktop to create the thumbnails and then applied the
> modifications on top of it inside the application, but that won't work very
> well if you consider crops.

We now have a thumbnailer (bug 690255) that can handle our edits. What's left to do is to tell it to re-create the thumbnail when edits are made to an item.
Comment 4 Debarshi Ray 2017-02-22 19:37:41 UTC
Patches in gnome-photos:wip/rishi/thumbnailer are now capable of updating the thumbnails. I'll merge them after some more testing.
Comment 5 Debarshi Ray 2017-02-23 09:38:44 UTC
Created attachment 346541 [details] [review]
thumbnailer-dbus: Add a Cancel method to support cancellation
Comment 6 Debarshi Ray 2017-02-23 09:38:56 UTC
Created attachment 346542 [details] [review]
thumbnailer: Use a GCancellable when handling GenerateThumbnail
Comment 7 Debarshi Ray 2017-02-23 09:39:21 UTC
Created attachment 346543 [details] [review]
thumbnailer: Track the invocations and cancellables of ongoing jobs
Comment 8 Debarshi Ray 2017-02-23 09:39:35 UTC
Created attachment 346544 [details] [review]
thumbnailer: Implement cancellation
Comment 9 Debarshi Ray 2017-02-23 09:39:50 UTC
Created attachment 346545 [details] [review]
thumbnail-factory: Implement cancellation
Comment 10 Debarshi Ray 2017-02-23 09:40:12 UTC
Created attachment 346546 [details] [review]
base-item: Use a GCancellable when creating a thumbnail
Comment 11 Debarshi Ray 2017-02-23 09:40:26 UTC
Created attachment 346547 [details] [review]
base-item: Delete the thumbnail if create_thumbnail was cancelled
Comment 12 Debarshi Ray 2017-02-23 09:40:43 UTC
Created attachment 346548 [details] [review]
base-item: Refresh the thumbnail whenever the pipeline is saved
Comment 13 Debarshi Ray 2017-06-30 18:16:06 UTC
Created attachment 354747 [details] [review]
thumbnailer: Fix typo and complete the right D-Bus call