After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762949 - switching an event to all day loses it's timezone
switching an event to all day loses it's timezone
Status: RESOLVED OBSOLETE
Product: gnome-calendar
Classification: Applications
Component: Edit dialog
3.19.x
Other Linux
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
: 779956 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-03-01 20:18 UTC by Marinus Schraal
Modified: 2017-11-24 21:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
edit-dialog: UTC timezone for all day events (2.51 KB, patch)
2016-10-18 01:47 UTC, Isaque Galdino
rejected Details | Review

Description Marinus Schraal 2016-03-01 20:18:35 UTC
When creating an event it gets a timezone (usually the local one). However setting it all-day sets the timezone to UTC, essentially losing the timezone information. Disabling all day then leaves the timezone unset and shifting the event by the timezone discrepancy.
Comment 1 Isaque Galdino 2016-10-12 01:09:39 UTC
Hi Marinus, this "feature" was added by this commit:
https://git.gnome.org/browse/gnome-calendar/commit/?id=e5cd5ba7f5f8ef78dfdc4b9c64f85d3e1ba4d648

So, just to make sure, the problem is not when we change the timezone to UTC when user set all day event, but when it doesn't get back to local timezone when user unset it, right?
Comment 2 Marinus Schraal 2016-10-12 22:10:31 UTC
Well I guess you can see it that way, but the problem really is that when you change to UTC you already lost your original timezone info.
Comment 3 Isaque Galdino 2016-10-18 01:47:20 UTC
Created attachment 337911 [details] [review]
edit-dialog: UTC timezone for all day events

Timezone is being changed to UTC when user sets the event to be all day.
Original timezone is then lost if user decides to set back to non all
day event.

This commit removes code responsible for changing timezone to UTC when
editing an event using the edit dialog.
Comment 4 Ryan Hendrickson 2017-01-18 02:44:13 UTC
I tried this patch, but it hurts more than it helps; now every time a not-all-day event is edited, its times shift by the local time zone amount.
Comment 5 Georges Basile Stavracas Neto 2017-02-21 11:20:16 UTC
Review of attachment 337911 [details] [review]:

We already discussed this issue on IRC (unfortunately lost the logs) and there's nothing we can really do. There's no way to store the previous timezone with libical.
Comment 6 Georges Basile Stavracas Neto 2017-04-17 18:42:54 UTC
*** Bug 779956 has been marked as a duplicate of this bug. ***
Comment 7 Georges Basile Stavracas Neto 2017-11-24 21:42:27 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-calendar/issues/43.