After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762817 - Request for chrome-gnome-shell Github mirror pull requests control
Request for chrome-gnome-shell Github mirror pull requests control
Status: RESOLVED WONTFIX
Product: sysadmin
Classification: Infrastructure
Component: Mirrors
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Sysadmins
GNOME Sysadmins
Depends on:
Blocks:
 
 
Reported: 2016-02-28 12:45 UTC by Yuri Konotopov
Modified: 2016-03-09 11:22 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Yuri Konotopov 2016-02-28 12:45:22 UTC
Hi,

I want to review and work with pull requests submitted via chrome-gnome-shell Github mirror: https://github.com/GNOME/chrome-gnome-shell.

I understand that PRs must not be directly merged via Github instead they should be merged through git.gnome.org.

If possible, please give me permissions to assign and close PRs for chrome-gnome-shell repository.

My Github account: https://github.com/nE0sIghT

Thanks.
Comment 1 Andrea Veri 2016-03-02 17:48:25 UTC
Added you as a collaborator for that specific repository. Feel free to re-open if you need more help!
Comment 2 Alberto Ruiz 2016-03-08 13:23:36 UTC
Andrea, I am afraid that doing this goes against our commitment to the community when we opened the mirror (no PRs, no issue tracking, just a plain mirror).

I'm afraid we have to revoke this.
Comment 3 Andrea Veri 2016-03-08 13:27:49 UTC
Alberto,

for a moment I thought the only point in having Yuri as a collaborator for that specific repository was for him to close the PRs on Github and open bug reports at bugzilla.gnome.org with the same content of the PRs themselves and not to use Github as an alternate workflow as that indeed goes against the original commitment.

I've revoked the access to the repository.
Comment 4 Yuri Konotopov 2016-03-08 21:02:45 UTC
Hi Alberto, Andrea.
I'm a bit confused by workflow you are described.

I searched early discussions and read [0] and [1]. Found unanswered [3].

First of all I have 1 question: as a project maintainer may I directly commit to maintained repository (at git.gnome.org) without some review process at bugzilla.gnome.org?

If answer "yes", what is a problem if I will review PRs at github mirror, communicate with PR author and manually merge PR through git.gnome.org (not through github "merge" button)?

[1] https://mail.gnome.org/archives/foundation-list/2013-August/msg00010.html
[2] https://mail.gnome.org/archives/desktop-devel-list/2015-May/msg00004.html
[3] https://mail.gnome.org/archives/foundation-list/2013-August/msg00076.html
Comment 5 Alberto Ruiz 2016-03-08 21:30:38 UTC
The problem is that we can't officially rely or encourage a piece of closed source software that we don't maintain to operate the GNOME development workflow. 

The mirror was not created to bypass Bugzilla, and we made a commitment not to encourage that sort of thing.

You are, however, free to use github PRs, just not on the GNOME mirror.
Comment 6 Yuri Konotopov 2016-03-09 11:22:15 UTC
Alberto, thanks for explanation. As I see now it is only a question of liberty/FOSS.

Please sorry my impudence, but my only goal is comfortable development process of chrome-gnome-shell.

Yes, I can set up another mirror for chrome-gnome-shell repository. However I need some server with some scripting. On other side you already done all work (btw thanks for that).

Moreover GNOME/ostree already works with PRs: https://github.com/GNOME/ostree/pulls?utf8=%E2%9C%93&q=is%3Apr.

It's OK for me not to have collaborator rights for repository mirror. Technically I can work with PRs without that.
However I want to respect your work and GNOME rules.

So may I ask you not to close PRs on GNOME/chrome-gnome-shell github mirror?
It will be OK for me if sometime in the future you will hide PRs entirely.