After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762422 - validate: Fix wrong condition check when adding tests
validate: Fix wrong condition check when adding tests
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
git master
Other Linux
: Normal normal
: 1.7.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-22 02:51 UTC by Vineeth
Modified: 2016-03-11 15:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix condition check while listing tests (1.62 KB, patch)
2016-02-22 02:52 UTC, Vineeth 		committed Details | Review

Description Vineeth 2016-02-22 02:51:17 UTC 
When listing tests, checking whether uri is present or not and displaying error.
But uri need not be present in case of pipeline generator. So the condition check is wrong.
This results in validateelements testsuite not working. Hence modifying the condition to just print error instead of skipping the add tests.
Comment 1 Vineeth 2016-02-22 02:52:13 UTC 
Created attachment 321801 [details] [review]
fix condition check while listing tests
Comment 2 Thibault Saunier 2016-03-05 12:02:13 UTC 
commit 7d9e9b3b79d1bc47b5dfb388651d4d0a768ef6ff
Author: Vineeth T M <vineeth.tm@samsung.com>
Date:   Mon Feb 22 11:49:48 2016 +0900

    validate: Fix wrong condition check when adding tests
    
    When listing tests, checking whether uri is present or not and displaying error.
    But uri does notneed to be present in case of pipeline generator. So the condition check is wrong.
    This results in validateelements testsuite not working. Hence modifying the condition to
    not error out on valid cases.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=762422