GNOME Bugzilla – Bug 761998
MyPaint brush popup out of screen
Last modified: 2018-05-24 16:09:51 UTC
The popup of the MyPaint brush is too big and the top is out of the screen, preventing one from getting top brushes. See screenshot. We should make sure the popup is constrained inside the current screen, in particular since we anyway have a scrollbar.
Created attachment 321075 [details] Screenshot showing the problem. Forgot the screenshot.
Oh, evil. I thought I had already added dynamic sizing for these popups...
Created attachment 321740 [details] [review] patch: make the popup smaller I have tried to change it to have the same size as the classical brush popup. Though it doesn't adapt to the screen size, and changing from either the list or grid view still changes the popup's size, I thought it would be better, for consistency sake, to change them later the same way.
Comment on attachment 321740 [details] [review] patch: make the popup smaller We can't do that because MyPaint brush previews have a fixed size of 48x48 and look crappy when scaled down. The way to fix this is to dynamically change the number of rows in the popup, but that code is in another place (not where we position the popup).
Created attachment 322746 [details] screenshot This is how the result looks to me, so I didn't think the actual brush preview would change/be made smaller? I believe I saw some pretty similar code for the other paint tool brushes as well. I understand, I will try to see how this could change.
Um, that is with the patch? I'll have to try that, it looks like it would just change the number of rows/columns, weird.
Jehan, is that better now? commit 9693ab92e735744730ba89ce48126bcf4703ba55 Author: Michael Natterer <mitch@gimp.org> Date: Sun Mar 20 21:34:37 2016 +0100 Bug 761998 - MyPaint brush popup out of screen Add a lame workaround to GimpContainerPopup (default to 6 instead of 10 rows of items if the view size is >= LARGE). app/widgets/gimpcontainerpopup.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-)
Oups sorry, completely forgot to review. Yep it's much better. Since, as you say, it's a workaround, we should still keep the report open until we find a better fix. At least, this should be OK in most cases, hence is not urgent now. So I'll just set to "Future" milestone.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/850.