GNOME Bugzilla – Bug 760616
Allow to dismiss completed operations in the popover
Last modified: 2021-06-18 15:32:56 UTC
I realized that one of the things I do not like in the new popover is that I never know if an operation really finishes... the progress bar seems to be at 100% but the (X) button to cancel is still there and I do not know if clicking on it will cancel or not. I think an easy way to improve this would be to change the (X) button into a (v) button with the "checkmark" icon once the operation is completed. Clicking on the button would just dismiss the operation from the list. If you used Skype file transfers, this would be somewhat similar.
Created attachment 319286 [details] [review] patch I quickly hacked this together while waiting for a long task to finish... The patch for the info widget should be okaish, but another part is missing: if we dismiss all operations we need to hide the popover and the toolbutton
(In reply to Paolo Borelli from comment #1) > Created attachment 319286 [details] [review] [review] > patch > > I quickly hacked this together while waiting for a long task to finish... > > The patch for the info widget should be okaish, but another part is missing: > if we dismiss all operations we need to hide the popover and the toolbutton Thanks for the patch! However as you say, I'm not sure it's fine to push this without the more complex part, hiding the popover if all operations are dismissed, which will probably involve make the progress info manager aware of it. Now we are at least consistent.
Created attachment 319372 [details] [review] patch I added the previous patch as a work in progress to not lose it. However it occurred to me that we can do things in two steps: 1) (this patch) just change the icon but keep the button insensitive and do not allow to dismiss manually. This should be completely save to apply 2) touch the manager to allow dismissing completed operations
Review of attachment 319372 [details] [review]: Sounds good!
Patch for (1) pushed. I am re-titling the bug for the other part.
Removing blocker status. It's mostly fine as it is.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version of Files (nautilus), then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/nautilus/-/issues/ Thank you for your understanding and your help.