After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760616 - Allow to dismiss completed operations in the popover
Allow to dismiss completed operations in the popover
Status: RESOLVED OBSOLETE
Product: nautilus
Classification: Core
Component: File and Folder Operations
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Paolo Borelli
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-14 10:19 UTC by Paolo Borelli
Modified: 2021-06-18 15:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (5.30 KB, patch)
2016-01-18 18:34 UTC, Paolo Borelli
none Details | Review
patch (5.29 KB, patch)
2016-01-19 18:26 UTC, Paolo Borelli
committed Details | Review

Description Paolo Borelli 2016-01-14 10:19:05 UTC
I realized that one of the things I do not like in the new popover is that I never know if an operation really finishes... the progress bar seems to be at 100% but the (X) button to cancel is still there and I do not know if clicking on it will cancel or not.


I think an easy way to improve this would be to change the (X) button into a (v) button with the "checkmark" icon once the operation is completed. Clicking on the button would just dismiss the operation from the list.


If you used Skype file transfers, this would be somewhat similar.
Comment 1 Paolo Borelli 2016-01-18 18:34:05 UTC
Created attachment 319286 [details] [review]
patch

I quickly hacked this together while waiting for a long task to finish...

The patch for the info widget should be okaish, but another part is missing: if we dismiss all operations we need to hide the popover and the toolbutton
Comment 2 Carlos Soriano 2016-01-18 18:51:40 UTC
(In reply to Paolo Borelli from comment #1)
> Created attachment 319286 [details] [review] [review]
> patch
> 
> I quickly hacked this together while waiting for a long task to finish...
> 
> The patch for the info widget should be okaish, but another part is missing:
> if we dismiss all operations we need to hide the popover and the toolbutton

Thanks for the patch!
However as you say, I'm not sure it's fine to push this without the more complex part, hiding the popover if all operations are dismissed, which will probably involve make the progress info manager aware of it.

Now we are at least consistent.
Comment 3 Paolo Borelli 2016-01-19 18:26:29 UTC
Created attachment 319372 [details] [review]
patch

I added the previous patch as a work in progress to not lose it.

However it occurred to me that we can do things in two steps:

1) (this patch) just change the icon but keep the button insensitive and do not allow to dismiss manually. This should be completely save to apply

2) touch the manager to allow dismissing completed operations
Comment 4 Carlos Soriano 2016-01-19 21:08:26 UTC
Review of attachment 319372 [details] [review]:

Sounds good!
Comment 5 Paolo Borelli 2016-01-19 22:52:05 UTC
Patch for (1) pushed. I am re-titling the bug for the other part.
Comment 6 Carlos Soriano 2016-02-23 17:18:22 UTC
Removing blocker status. It's mostly fine as it is.
Comment 7 André Klapper 2021-06-18 15:32:56 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version of Files (nautilus), then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/nautilus/-/issues/

Thank you for your understanding and your help.