After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760426 - [PATCH] grl-inspect-0.3 --help and grl-launch-0.3 --help shows translated characters as question marks on some locales
[PATCH] grl-inspect-0.3 --help and grl-launch-0.3 --help shows translated cha...
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: general
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2016-01-11 06:09 UTC by Ting-Wei Lan
Modified: 2016-01-12 12:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
grl-inspect, grl-launch: Call setlocale in main function (1.69 KB, patch)
2016-01-11 06:09 UTC, Ting-Wei Lan 		none Details | Review
grl-inspect: Fix help messages in some locales (1.04 KB, patch)
2016-01-11 12:30 UTC, Ting-Wei Lan 		committed Details | Review
grl-launch: Fix help messages in some locales (1001 bytes, patch)
2016-01-11 12:30 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2016-01-11 06:09:19 UTC 
Please see the attached patch. grl-inspect and grl-launch should call setlocale in main function in order to correctly show translated messages.
Comment 1 Ting-Wei Lan 2016-01-11 06:09:38 UTC 
Created attachment 318695 [details] [review]
grl-inspect, grl-launch: Call setlocale in main function

It is required to correctly show translated messages on some locales.
Comment 2 Bastien Nocera 2016-01-11 10:38:01 UTC 
Review of attachment 318695 [details] [review]:

Please split the changes, and fix the commit message to match this one:
https://git.gnome.org/browse/totem/commit/?id=8ed76341025868862f380f40704b9d4683b1eca0
Comment 3 Ting-Wei Lan 2016-01-11 12:30:06 UTC 
Created attachment 318716 [details] [review]
grl-inspect: Fix help messages in some locales

Call setlocale() first thing in the main() function
Comment 4 Ting-Wei Lan 2016-01-11 12:30:21 UTC 
Created attachment 318717 [details] [review]
grl-launch: Fix help messages in some locales

Call setlocale() first thing in the main() function
Comment 5 Bastien Nocera 2016-01-12 12:41:07 UTC 
Attachment 318716 [details] pushed as 79bbf6a - grl-inspect: Fix help messages in some locales
Attachment 318717 [details] pushed as 7158c4c - grl-launch: Fix help messages in some locales
Comment 6 Bastien Nocera 2016-01-12 12:49:45 UTC 
Pushed to master and the 0.2.x branch.