After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760177 - Fix non-literal format string warning for clang
Fix non-literal format string warning for clang
Status: RESOLVED FIXED
Product: libgxps
Classification: Platform
Component: general
unspecified
Other FreeBSD
: Normal normal
: ---
Assigned To: libgxps maintainers
libgxps maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-05 19:07 UTC by Ting-Wei Lan
Modified: 2016-01-10 09:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gxps-images: Fix non-literal format string warning for clang (663 bytes, patch)
2016-01-05 19:08 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2016-01-05 19:07:53 UTC 
This error message shows when compiling libgxps with clang:

gxps-images.c:619:34: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
        _tiff_error = g_strdup_vprintf (fmt, ap);
                                        ^~~
1 error generated.

Please see the patch. This can be easily fixed by using G_GNUC_PRINTF.
Comment 1 Ting-Wei Lan 2016-01-05 19:08:38 UTC 
Created attachment 318279 [details] [review]
gxps-images: Fix non-literal format string warning for clang
Comment 2 Carlos Garcia Campos 2016-01-10 09:42:37 UTC 
Comment on attachment 318279 [details] [review]
gxps-images: Fix non-literal format string warning for clang

Pushed, thank you!