After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760174 - sys/prctl.h should only be included on Linux
sys/prctl.h should only be included on Linux
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: libide
unspecified
Other FreeBSD
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-05 18:52 UTC by Ting-Wei Lan
Modified: 2016-01-06 06:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libide: don't include sys/prctl.h on non-Linux systems (761 bytes, patch)
2016-01-05 18:55 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2016-01-05 18:52:01 UTC 
sys/prctl.h is a Linux-specific header, so we should only include it on Linux.
Comment 1 Ting-Wei Lan 2016-01-05 18:55:11 UTC 
Created attachment 318276 [details] [review]
libide: don't include sys/prctl.h on non-Linux systems
Comment 2 sébastien lafargue 2016-01-05 21:01:10 UTC 
Review of attachment 318276 [details] [review]:

we use it like this:

#ifdef __linux
  /* Ensure we are killed with our parent */
  prctl (PR_SET_PDEATHSIG, 15);
#endif

so LGTM
Comment 3 Ting-Wei Lan 2016-01-06 06:44:04 UTC 
Attachment 318276 [details] pushed as dd067e9 - libide: don't include sys/prctl.h on non-Linux systems