GNOME Bugzilla – Bug 759786
Add a warning message with MIME type if no matching loader found
Last modified: 2018-05-22 13:19:12 UTC
Created attachment 317794 [details] [review] Patch adding warning message Would make it easier to debug MIME database problems that prevent images loading. Patch attached.
This function already returns a GError. It would be rather obnoxious if it output warnings on console; but the GError message might be improved by adding the mime type to it.
Created attachment 317824 [details] [review] Add guessed MIME type to unknown image format error Only possible by adding a number of #ifdef's (attached) or duplicating code?
Review of attachment 317824 [details] [review]: ::: gdk-pixbuf/gdk-pixbuf-io.c @@ +943,3 @@ + _("Couldn't recognize the image file format for file '%s'" +#ifdef GDK_PIXBUF_USE_GIO_MIME + "\nGuessed MIME type '%s'" Two problems here: - there's no way gettext will be able to work with this. - There shouldn't be a linefeed in the error message.
Review of attachment 317794 [details] [review]: As per chpe's comment
Created attachment 342338 [details] [review] Add the unknown MIME type to error message Updated to: * Make the messages all single strings * Add braces with the first use of #ifdef because when true the if has two statements * Keep the g_set_error_literal for the #else of the third #ifdef
Created attachment 370819 [details] [review] Add the unknown MIME type to error message Updated for gdk-pixbuf-2.36.12.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gdk-pixbuf/issues/53.