After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758728 - id3mux: write private data tag
id3mux: write private data tag
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other Linux
: Normal enhancement
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-27 05:48 UTC by RaviKiran
Modified: 2015-11-27 12:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
write private data in id3mux (2.87 KB, patch)
2015-11-27 05:51 UTC, RaviKiran 		committed Details | Review

Description RaviKiran 2015-11-27 05:48:36 UTC 
Follow-up of bug 730926
Write GST_TAG_PRIVATE_DATA tag (Id3v2 "PRIV" tag) in id3mux.
Comment 1 RaviKiran 2015-11-27 05:51:53 UTC 
Created attachment 316363 [details] [review]
write private data in id3mux

Patch attached. Please review.
Comment 2 Tim-Philipp Müller 2015-11-27 12:46:35 UTC 
Thanks a lot, pushed:

ommit a7475bfc6c8d1ce560a48a2d4dfca50a697dae1a
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Fri Nov 27 12:44:57 2015 +0000

    tests: id3mux: add unit test for GST_TAG_PRIVATE_DATA writing
    
    https://bugzilla.gnome.org/show_bug.cgi?id=758728

commit 6b643fdff64a9f0412e7247f343021d92602b3a1
Author: Ravi Kiran K N <ravi.kiran@samsung.com>
Date:   Fri Nov 27 11:33:07 2015 +0530

    id3mux: write private data tag
    
    Handle "PRIV" tag in id3mux. Write owner
    identifier and private data and add to the
    id3v2 frame.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=758728