After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758233 - mpdparser: remove unused functions gst_mpdparser_get_chunk_by_index and gst_mpdparser_find_segment_by_index
mpdparser: remove unused functions gst_mpdparser_get_chunk_by_index and gst_m...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-17 15:33 UTC by Florin Apostol
Modified: 2015-11-19 19:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (4.88 KB, patch)
2015-11-19 16:04 UTC, Florin Apostol
committed Details | Review

Description Florin Apostol 2015-11-17 15:33:50 UTC
gst_mpdparser_get_chunk_by_index and gst_mpdparser_find_segment_by_index are unused. Should we remove them?

If we decide to keep them, there are a few problems to be fixed:
- gst_mpdparser_find_segment_by_index does not set the repeat field.
- gst_mpdparser_get_chunk_by_index, when asked to retrieve chunk indexChunk, will retrieve the next one (the first thing it does is to increment indexChunk). The function has no comments and is not used, so I can't figure out if this is correct or not. From an API point of view, is completely non-intuitive.

Once a decision to remove/fix is taken, I can implement the changes.
Comment 1 Thiago Sousa Santos 2015-11-17 19:21:52 UTC
I'd just remove those, there were lots of changes to accommodate the template generation and repeated entries to use less memory. Those look like leftovers after those changes.
Comment 2 Florin Apostol 2015-11-19 16:04:06 UTC
Created attachment 315898 [details] [review]
proposed patch
Comment 3 Thiago Sousa Santos 2015-11-19 19:06:16 UTC
commit ef84f294c01bcc0b0fc88a872937806154e0283a
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Thu Nov 19 15:59:56 2015 +0000

    mpdparser: remove unused functions gst_mpdparser_get_chunk_by_index and gst_mpdparser_find_segment_by_index
    
    https://bugzilla.gnome.org/show_bug.cgi?id=758233