After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758030 - Don't assume X
Don't assume X
Product: sushi
Classification: Core
Component: general
Other All
: Normal normal
: ---
Assigned To: Sushi maintainer(s)
Sushi maintainer(s)
Depends on:
Reported: 2015-11-12 20:03 UTC by Matthias Clasen
Modified: 2015-11-14 19:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Don't assume X (1.27 KB, patch)
2015-11-12 20:03 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2015-11-12 20:03:18 UTC
We must do a runtime check for X11, before calling gdk_x11 api.
This does not fix sushi under Wayland, but it gets it far enough
to show a window.
Comment 1 Matthias Clasen 2015-11-12 20:03:21 UTC
Created attachment 315365 [details] [review]
Don't assume X
Comment 2 Cosimo Cecchi 2015-11-12 20:21:36 UTC
Review of attachment 315365 [details] [review]:

Looks good to me.
Comment 3 Cosimo Cecchi 2015-11-14 19:05:21 UTC
Pushed to master.

Attachment 315365 [details] pushed as 020ed85 - Don't assume X