After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757742 - Fix up annotations in ghash.c
Fix up annotations in ghash.c
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: introspection
unspecified
Other All
: Normal minor
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-11-07 16:55 UTC by Mikhail Zabaluev
Modified: 2015-11-08 12:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ghash: Correctly annotate (nullable) and (out) parameters (3.62 KB, patch)
2015-11-07 16:55 UTC, Mikhail Zabaluev 		committed Details | Review
Return value of g_hash_table_get_{keys,values} is (transfer container) (1.81 KB, patch)
2015-11-07 16:55 UTC, Mikhail Zabaluev 		committed Details | Review

Description Mikhail Zabaluev 2015-11-07 16:55:30 UTC 
There is a number of obsolete or missing annotations in ghash.c.
The attached patches correct the annotations.
Comment 1 Mikhail Zabaluev 2015-11-07 16:55:34 UTC 
Created attachment 315059 [details] [review]
ghash: Correctly annotate (nullable) and (out) parameters
Comment 2 Mikhail Zabaluev 2015-11-07 16:55:40 UTC 
Created attachment 315060 [details] [review]
Return value of g_hash_table_get_{keys,values} is (transfer container)
Comment 3 Colin Walters 2015-11-08 02:12:34 UTC 
Review of attachment 315059 [details] [review]:

Looks good to me.
Comment 4 Colin Walters 2015-11-08 02:12:54 UTC 
Review of attachment 315060 [details] [review]:

Right.
Comment 5 Mikhail Zabaluev 2015-11-08 12:34:59 UTC 
Attachment 315059 [details] pushed as 42463b8 - ghash: Correctly annotate (nullable) and (out) parameters
Attachment 315060 [details] pushed as 0a10d38 - Return value of g_hash_table_get_{keys,values} is (transfer container)