After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757421 - GNOME-Mud sends telnet subnegotiations one byte at a time
GNOME-Mud sends telnet subnegotiations one byte at a time
Status: RESOLVED OBSOLETE
Product: gnome-mud
Classification: Other
Component: general
0.11.x
Other Linux
: Normal minor
: ---
Assigned To: GNOME MUD Maintainers
GNOME MUD Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-01 01:14 UTC by Chris Wright
Modified: 2017-12-06 16:28 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Chris Wright 2015-11-01 01:14:56 UTC
In src/mud-telnet.c:671, the function mud_telnet_send_sub_req (and subsequent function mud_telnet_send_raw) sends data one byte at a time. Everywhere it's used, it's got a fixed size sequence to send, so it would be relatively trivial to fix this.

That's one byte per packet. That's a 4000% overhead. (Granted, these things aren't sent very often...)

Furthermore, it's much more convenient on the server side if short options are sent in a single packet. Multiple packets means multiple calls to receive(), forcing another layer of buffering or more complex buffering, etc.
Comment 1 Chris Wright 2015-11-01 01:52:10 UTC
It looks like gnet does minimal output buffering. Sometimes I get one packet per byte, sometimes I get IAC in one packet and the rest in another.
Comment 2 GNOME Infrastructure Team 2017-12-06 16:28:52 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-mud/issues/17.