After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756981 - ui: Add shortcuts help
ui: Add shortcuts help
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-22 16:52 UTC by Florian Müllner
Modified: 2015-10-24 10:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ui: Add shortcuts help (10.51 KB, patch)
2015-10-22 16:52 UTC, Florian Müllner 		none Details | Review
ui: Add shortcuts help (6.19 KB, patch)
2015-10-23 11:46 UTC, Florian Müllner 		committed Details | Review
greyed out keyboard shortcuts overview (62.14 KB, image/png)
2015-10-24 06:58 UTC, Bastian Ilsø 		  Details

Description Florian Müllner 2015-10-22 16:52:38 UTC 
See patch.

This depends on the (yet unmerged) wip/matthiasc/help-overlay GTK+ branch.
Comment 1 Florian Müllner 2015-10-22 16:52:41 UTC 
Created attachment 313875 [details] [review]
ui: Add shortcuts help

Use GTK+'s new shortcut window to document our shortcuts.
Comment 2 Florian Müllner 2015-10-23 11:46:33 UTC 
Created attachment 313934 [details] [review]
ui: Add shortcuts help

Help overlays landed in GTK+ master, including some nice sugar as shortcut ranges and resource automagic - update the patch to make use of that.
Comment 3 Florian Müllner 2015-10-23 11:49:52 UTC 
Attachment 313934 [details] pushed as 97c60c3 - ui: Add shortcuts help
Comment 4 Bastian Ilsø 2015-10-24 06:58:49 UTC 
Created attachment 314000 [details]
greyed out keyboard shortcuts overview

i compiled mathias' branch and tried testing this but the option seems greyed out (?)
Comment 5 Florian Müllner 2015-10-24 08:32:24 UTC 
(In reply to Bastian Ilsø from comment #4)
> i compiled mathias' branch

See comment #2 - the branch is outdated, the feature is now in GTK+ master.
Comment 6 Bastian Ilsø 2015-10-24 10:02:21 UTC 
(In reply to Florian Müllner from comment #5)
> See comment #2 - the branch is outdated, the feature is now in GTK+ master.

Got it working, it's awesome! :)