After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755090 - gnome-music should coalesce MPRIS property changes into one PropertiesChanged signal per event
gnome-music should coalesce MPRIS property changes into one PropertiesChanged...
Status: RESOLVED OBSOLETE
Product: gnome-music
Classification: Applications
Component: general
3.16.x
Other Linux
: Low minor
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2015-09-16 06:41 UTC by Michael Gratton
Modified: 2018-01-10 14:45 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Michael Gratton 2015-09-16 06:41:30 UTC
Currently, gnome-music sends multiple PropertiesChanged DBus signals when tracks start and stop playing. I see the following from the org.mpris.MediaPlayer2.Player interface along:

Seven signals on playback start, with the following values:

1. Tracks=[...]
2. ActivePlaylist={...} 
3. Metadata={...}, CanPause=1, CanPlay=1
4. CanGoPrevious=0, CanGoNext=0
5. Metadata={...}, CanPause=0, CanPlay=1
6. PlaybackStatus: Playing
7. Metadata={...}

Three signals on playback stop, with the following values:

1. CanGoNext=0, CanGoPrevious=0
2. CanPlay=0, Metadata={...}
3. Metadata={...}

There's lot of unneeded IPC and wakeups there, also a fair bit of redundancy - especially for the Metadata fields, which are all identical and hence should actually only get reported as having changed once for each track, not up to 5 times.
Comment 1 Marinus Schraal 2016-05-15 19:31:52 UTC
Fair enough, patch appreciated.
Comment 2 Marinus Schraal 2016-05-15 20:12:31 UTC
wrong status
Comment 3 GNOME Infrastructure Team 2018-01-10 14:45:55 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-music/issues/43.