After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754578 - places: Include DESKTOP when desktop icons are enabled
places: Include DESKTOP when desktop icons are enabled
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-09-04 14:54 UTC by Florian Müllner
Modified: 2015-09-04 15:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
places: Include DESKTOP when desktop icons are enabled (4.16 KB, patch)
2015-09-04 14:54 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2015-09-04 14:54:21 UTC 
See patch.
Comment 1 Florian Müllner 2015-09-04 14:54:25 UTC 
Created attachment 310672 [details] [review]
places: Include DESKTOP when desktop icons are enabled

The user explicitly enabling desktop icons is a pretty good hint
that she intends to use the Desktop folder, so be consistent with
GTK+ and nautilus and include it when the corresponding setting
is true.
Comment 2 Rui Matos 2015-09-04 15:22:49 UTC 
Review of attachment 310672 [details] [review]:

Otherwise looks good

::: extensions/places-menu/placeDisplay.js
@@ +196,3 @@
         };
 
+        this._settings = new Gio.Settings({ schema_id: BACKGROUND_SCHEMA });

we should get rid of this reference on destroy()
Comment 3 Florian Müllner 2015-09-04 15:51:01 UTC 
Attachment 310672 [details] pushed as 547163e - places: Include DESKTOP when desktop icons are enabled