After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753625 - splitmuxsrc: add "format-location" signal as a way to specify arbitrarily named files as input
splitmuxsrc: add "format-location" signal as a way to specify arbitrarily nam...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-14 12:08 UTC by George Kiagiadakis
Modified: 2016-05-05 09:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
splitmuxsrc: support taking a sorted list of files as input in the location property (1.59 KB, patch)
2015-08-14 12:08 UTC, George Kiagiadakis
none Details | Review
splitmuxsrc: add a format-location signal that allows bypassing the location property (2.87 KB, patch)
2015-11-09 16:56 UTC, George Kiagiadakis
committed Details | Review
tests/check: add a splitmuxsrc test for its "format-location" signal (2.16 KB, patch)
2015-11-09 16:57 UTC, George Kiagiadakis
committed Details | Review

Description George Kiagiadakis 2015-08-14 12:08:29 UTC
Created attachment 309263 [details] [review]
splitmuxsrc: support taking a sorted list of files as input in the location property

Complementary to https://bugzilla.gnome.org/show_bug.cgi?id=750106 , there is a need to be able to give splitmuxsrc a list of files that are not named after the usual numbered pattern.

I wrote a patch for that that abuses the splitmux uri to be able to give a list of files. The list is meant to work like this:

splitmux://list?/path/to/file1.mp4+/path/to/file2.mp4+/path/to/file3.mp4

It looks a bit ugly, so I'm not sure if we want to do it this way, but it works quite well.
Comment 1 Tim-Philipp Müller 2015-08-15 09:42:37 UTC
I don't know, I'm not very keen on this.

I don't think it's needed now that there is the "format-location" signal.
Comment 2 George Kiagiadakis 2015-08-15 09:54:21 UTC
Hmm, you misunderstood. The "format-location" signal is on *splitmuxsink*. After the files have been written with custom names, though, *splitmuxsrc* needs a way to take them as input. This is what this bug is about.
Comment 3 Jan Schmidt 2015-08-22 10:50:16 UTC
I'm not too sure about the magic URI. What about a corresponding signal on splitmuxsrc to request the fragment list? Not really any reason they have to be filenames at that point - they could be URIs too
Comment 4 George Kiagiadakis 2015-08-22 11:41:38 UTC
Right, I've discussed it with Tim a bit already and we concluded on a signal as well. Of course, the advantage of an URI is that you can use it in gst-launch, but I guess it won't be that useful as a feature.

I'll work on it as soon as I can.
Comment 5 George Kiagiadakis 2015-11-09 16:56:51 UTC
Created attachment 315134 [details] [review]
splitmuxsrc: add a format-location signal that allows bypassing the location property
Comment 6 George Kiagiadakis 2015-11-09 16:57:12 UTC
Created attachment 315135 [details] [review]
tests/check: add a splitmuxsrc test for its "format-location" signal
Comment 7 Tim-Philipp Müller 2016-05-03 16:45:04 UTC
Comment on attachment 315135 [details] [review]
tests/check: add a splitmuxsrc test for its "format-location" signal

Sorry for the delay, looks good to me!
Comment 8 Tim-Philipp Müller 2016-05-05 09:55:27 UTC
commit c0dd2029e989e825be2bf8a0c63d3cf07d355140
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Mon Nov 9 17:55:09 2015 +0100

    tests: add splitmuxsrc test for new "format-location" signal
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753625

commit bd2a1487cc464910d19bfb8f5f5e3a255d844c2d
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Mon Nov 9 17:51:12 2015 +0100

    splitmuxsrc: add a format-location signal that allows bypassing the location property
    
    This signal allows a user to directly return a sorted list of
    files to be joined, so that they don't have to follow the
    filename pattern that the "location" property expects.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753625