GNOME Bugzilla – Bug 753284
GtkFileChooser segfault when compiling with clang
Last modified: 2015-08-05 15:32:21 UTC
In gtk/gtkplacesview.c, function listbox_header_func: label = g_object_new (GTK_TYPE_LABEL, "hexpand", TRUE, "use_markup", TRUE, "label", text, "xalign", 0, NULL); xalign property is a float, but int is used here. This crashes applications using GtkFileChooser on x86_64.
Created attachment 308797 [details] [review] placesview: Fix wrong property type when creating a GtkLabel The type of xalign property of GtkLabel is float, not int. Using wrong type crashes GtkFileChooser on x86_64 when compiling with clang.
Review of attachment 308797 [details] [review]: good catch, thanks
Attachment 308797 [details] pushed as 68e00e9 - placesview: Fix wrong property type when creating a GtkLabel